After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739337 - simple install: Use CC and CFLAGS from environment
simple install: Use CC and CFLAGS from environment
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-10-29 07:56 UTC by Marcus Karlsson
Modified: 2016-01-27 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple install: Use CC and CFLAGS from environment (752 bytes, patch)
2014-10-29 07:59 UTC, Marcus Karlsson 		none Details | Review

Description Marcus Karlsson 2014-10-29 07:56:01 UTC 
It is usually possible to override CC and CFLAGS using environment variables with the same names. Jhbuild does not allow this when using the simple install option.
Comment 1 Marcus Karlsson 2014-10-29 07:59:19 UTC 
Created attachment 289564 [details] [review]
simple install: Use CC and CFLAGS from environment

This patch modifies Makefile.plain so that CC and CFLAGS are only assigned to the default value if they don't already have a value, similar to how the MAKE variable is already assigned.
Comment 2 Frederic Peters 2016-01-27 15:53:20 UTC 
(cleaning up jhbuild bug reports, pushed this one, thanks).

commit cc6591890084bd9509915f29e7c7a485caef0dcf
Author: Marcus Karlsson <mk@acc.umu.se>
Date:   Wed Oct 29 08:44:08 2014 +0100

    simple install: Use CC and CFLAGS from environment
    
    Unlike the MAKE variable both CC and CFLAGS are not taken from the
    environment. Allow these variables to be overridden using environment
    variables.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739337