GNOME Bugzilla – Bug 739335
Patch for GNOME Goal: Use g_timeout_add_seconds instead g_timeout_add
Last modified: 2015-02-04 21:04:14 UTC
This patch replaces g_timeout_add calls in eog application to g_timeout_add_seconds as per the GNOME goal component.
Created attachment 289563 [details] [review]
Review of attachment 289563 [details] [review]:
Thanks for the contribution. However, I don't see anything in the patch changing the intervals, but only the name of the method called. This will result in huge timeouts, e.g. 150 seconds instead of 150 ms. Am I missing something?
And also, there's no need to leave the old calls there commented out.
Sorry for not responding earlier, I seem to have missed it somehow.
Thanks, for giving the GnomeGoal a try. However, besides the problem Robert already pointed out, we use the normal g_timeout_add call on purpose here.
These timeouts are for example used for timing the frame change when displaying GIF animations and as such the subsecond accuracy of the timers is required here.