After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739335 - Patch for GNOME Goal: Use g_timeout_add_seconds instead g_timeout_add
Patch for GNOME Goal: Use g_timeout_add_seconds instead g_timeout_add
Product: eog
Classification: Core
Component: collection
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Reported: 2014-10-29 07:29 UTC by Prema
Modified: 2015-02-04 21:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

g_time_out_add_seconds patch (2.75 KB, patch)
2014-10-29 07:31 UTC, Prema
needs-work Details | Review

Description Prema 2014-10-29 07:29:46 UTC
This patch replaces g_timeout_add calls in eog application to g_timeout_add_seconds as per the GNOME goal component. 

Comment 1 Prema 2014-10-29 07:31:25 UTC
Created attachment 289563 [details] [review]
g_time_out_add_seconds patch
Comment 2 Robert Roth 2015-01-05 19:41:25 UTC
Review of attachment 289563 [details] [review]:

Thanks for the contribution. However, I don't see anything in the patch changing the intervals, but only the name of the method called. This will result in huge timeouts, e.g. 150 seconds instead of 150 ms. Am I missing something?
And also, there's no need to leave the old calls there commented out.
Comment 3 Felix Riemann 2015-02-04 21:04:14 UTC
Sorry for not responding earlier, I seem to have missed it somehow.

Thanks, for giving the GnomeGoal a try. However, besides the problem Robert already pointed out, we use the normal g_timeout_add call on purpose here.

These timeouts are for example used for timing the frame change when displaying GIF animations and as such the subsecond accuracy of the timers is required here.