After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739305 - souphttpsrc: log connection events at info level
souphttpsrc: log connection events at info level
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Low trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2014-10-28 15:37 UTC by Branislav Katreniak
Modified: 2014-11-24 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

0001-souphttpsrc-log-connection-events-at-info-level.patch (2.64 KB, patch)
2014-11-20 13:28 UTC, Branislav Katreniak
needs-work Details | Review
0001-souphttpsrc-log-connection-events-at-info-level.patch (2.79 KB, patch)
2014-11-21 10:39 UTC, Branislav Katreniak
committed Details | Review

Description Branislav Katreniak 2014-10-28 15:37:35 UTC
Soup connection events are non repeating. They get lost in noise at debug level.

We carry on this patch, I believe it can be interesting to others.
Comment 1 Reynaldo H. Verdejo Pinochet 2014-11-19 19:26:36 UTC
I'm guessing you meant to attach a patch?
Comment 2 Branislav Katreniak 2014-11-20 13:28:04 UTC
Created attachment 291099 [details] [review]

Patch working against 1.4.3 branch
Comment 3 Reynaldo H. Verdejo Pinochet 2014-11-20 14:59:08 UTC
Comment on attachment 291099 [details] [review]

>From bc1a515335d13a50ab98737ded8a9002aa53b87c Mon Sep 17 00:00:00 2001
>From: Branislav Katreniak <>
>Date: Tue, 25 Feb 2014 13:28:06 +0100
>Subject: [PATCH 1/2] souphttpsrc: log connection events at info level
>These events are non repeating. They get lost at debug level.

While I agree these belong to the INFO category rather
than the DEBUG one, I don't understand your "non repeating"
nor your "get lost". Can you elaborate and/or rephrase
your commit message?

> [..]
>diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c
>index ad87223..db3b594 100644
>--- a/ext/soup/gstsouphttpsrc.c
>+++ b/ext/soup/gstsouphttpsrc.c
>@@ -1265,7 +1265,8 @@ gst_soup_http_src_finished_cb (SoupMessage * msg, GstSoupHTTPSrc * src)
>     GST_DEBUG_OBJECT (src, "finished, but not for current message");
>     return;
>   }
>-  GST_DEBUG_OBJECT (src, "finished");
>+  GST_INFO_OBJECT (src, "finished, session_io_status:%d",
>+      src->session_io_status);

Add a space after ":" as it's done in the rest of the code.

Looks good otherwise. Thanks.
Comment 4 Branislav Katreniak 2014-11-21 10:39:25 UTC
Created attachment 291146 [details] [review]

Comments addressed:
* non-sense text from git message removed
* added space after : in io_status log message

Additional changes compared to previos patch:
* EOS message stays at DEBUG. It is not really connection related.
* CANCEL is logged at INFO. Looking at the code, nothing would be logged at INFO.
Comment 5 Tim-Philipp Müller 2014-11-22 15:16:12 UTC
Thanks, pushed:

commit 1e03ffb820a736c073391eed242b59e790e4d1ec
Author: Branislav Katreniak <>
Date:   Fri Nov 21 11:21:18 2014 +0100

    souphttpsrc: log connection events at info level

(shortened the io status line a little)
Comment 6 Tim-Philipp Müller 2014-11-22 15:21:07 UTC
(Didn't notice the ASSIGNED until after I'd pushed it, sorry)
Comment 7 Reynaldo H. Verdejo Pinochet 2014-11-24 16:21:07 UTC
It's OK. Thanks for taking care of it ;)