After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739290 - Avoid a hard dependency on gtk-update-icon-cache
Avoid a hard dependency on gtk-update-icon-cache
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2014-10-28 11:33 UTC by Kalev Lember
Modified: 2014-10-29 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Avoid a hard dependency on gtk-update-icon-cache (1.30 KB, patch)
2014-10-28 11:35 UTC, Kalev Lember
committed Details | Review

Description Kalev Lember 2014-10-28 11:33:50 UTC
We already have Makefile.am conditionals that only run gtk-update-icon-cache when doing 'make install' manually. For most distro builds, gtk-update-icon-cache gets never run during build, but we were still unconditionally checking for it during the configure run.

This makes distro bootstrapping hard, creating a circular dependency between gtk+ and adwaita-icon-theme. Attached patch relaxes the configure check to make this easier.
Comment 1 Kalev Lember 2014-10-28 11:35:52 UTC
Created attachment 289513 [details] [review]
Avoid a hard dependency on gtk-update-icon-cache

This makes is possible to build adwaita-icon-theme before gtk+ and
avoids a circular dependency between those two modules.
Comment 2 Jakub Steiner 2014-10-29 14:32:44 UTC
Attachment 289513 [details] pushed as 3227136 - Avoid a hard dependency on gtk-update-icon-cache