After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739251 - Implement GstValidate scenario serialization
Implement GstValidate scenario serialization
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: High enhancement
: 0.95
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-27 15:41 UTC by Thibault Saunier
Modified: 2014-11-22 22:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
undo: Undo redo logic for assets is now implemented in project. (3.51 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
undo: Disconnect from the signals correctly. (1.28 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
mainwindow: improve signal disconnecting. (7.57 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
Start implementing scenario serialization (2.54 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
scenarios: add the type of the added asset (844 bytes, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
scenario: serialize action even if running (1.58 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
scenarios: serialize asset removed (997 bytes, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
scenarios: adding asset requires an id, not an uri (1.32 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
undo: disconnect correct handlers when layer is removed. (929 bytes, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
undo: No need for class attribute actions. (2.68 KB, patch)
2014-10-27 15:42 UTC, Thibault Saunier
none Details | Review
undo: Add LayerAdded and LayerRemoved actions. (1.78 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
scenarios: serialize layer addition and removal (1.46 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
scenarios: serialize clip addtion / removal (1.27 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
scenarios: The log file now belongs to the application itself. (6.21 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
scenarios: Serialize play / pause (1.31 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
previewers: hardcoded path manipulations are bad. (1.08 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
scenarios: put scenario files in a cache directory. (1.90 KB, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
utils/timeline: remove unused imports (793 bytes, patch)
2014-10-27 15:43 UTC, Thibault Saunier
none Details | Review
pitivi: Add a way to let user decide where to save scenario files (2.44 KB, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
project: Override GES.Timeline.commit to save commit actions (1.45 KB, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
Serialize the start/inpoint/duration of the add-clip action (1016 bytes, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
utils:timeline: Serialize action for container editing (4.12 KB, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
Serialize seek actions and fix state change action serialization (4.15 KB, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
autopep8 WORKS, let's just use it! (426.40 KB, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
Encourage developers to use autopep8 (1.11 KB, patch)
2014-10-27 15:44 UTC, Thibault Saunier
none Details | Review
Serialize GES.Clip.split actions (2.85 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
project: Serialize the setting of GES.Track.restriction_caps (971 bytes, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
Serialize the setting of asset on transition (5.43 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
application: Add 'wait' action between actions (2.00 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
clipproperties: Commit the timeline when removing an efect (1.37 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
effect: Serialize effect related actions (2.05 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
undo:timeline: Do not track transitions addition (1.52 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
undo: Rename effect related tracker to TrackElement (12.58 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
undo: Remove the effect.py file and move its content to timeline.py (15.95 KB, patch)
2014-10-27 15:45 UTC, Thibault Saunier
none Details | Review
titleeditor: Implement Undo Redo (13.83 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review
Fix the testsuite (4.55 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review
bin:environment: Do not override user shell preferences (1.11 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review
undo: Reimplement undo/redo for Keyframes. (16.57 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review
Serialize KeyFrame in the scenario files (5.04 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review
project: Factor out a functio to check backup project (2.93 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review
mainwindow: Do not use no existing variables (1.10 KB, patch)
2014-10-27 15:46 UTC, Thibault Saunier
none Details | Review

Description Thibault Saunier 2014-10-27 15:41:30 UTC
Pitivi should be able to serialize all action from user into the GstValidate
scenario file format so that we can debug the issue user faces by just reproducing the exact same scenario later on.
Comment 1 Thibault Saunier 2014-10-27 15:42:02 UTC
Created attachment 289418 [details] [review]
undo: Undo redo logic for assets is now implemented in project.
Comment 2 Thibault Saunier 2014-10-27 15:42:07 UTC
Created attachment 289419 [details] [review]
undo: Disconnect from the signals correctly.
Comment 3 Thibault Saunier 2014-10-27 15:42:12 UTC
Created attachment 289420 [details] [review]
mainwindow: improve signal disconnecting.
Comment 4 Thibault Saunier 2014-10-27 15:42:17 UTC
Created attachment 289421 [details] [review]
Start implementing scenario serialization
Comment 5 Thibault Saunier 2014-10-27 15:42:24 UTC
Created attachment 289422 [details] [review]
scenarios: add the type of the added asset
Comment 6 Thibault Saunier 2014-10-27 15:42:29 UTC
Created attachment 289423 [details] [review]
scenario: serialize action even if running
Comment 7 Thibault Saunier 2014-10-27 15:42:34 UTC
Created attachment 289424 [details] [review]
scenarios: serialize asset removed
Comment 8 Thibault Saunier 2014-10-27 15:42:42 UTC
Created attachment 289425 [details] [review]
scenarios: adding asset requires an id, not an uri
Comment 9 Thibault Saunier 2014-10-27 15:42:48 UTC
Created attachment 289426 [details] [review]
undo: disconnect correct handlers when layer is removed.
Comment 10 Thibault Saunier 2014-10-27 15:42:54 UTC
Created attachment 289427 [details] [review]
undo: No need for class attribute actions.
Comment 11 Thibault Saunier 2014-10-27 15:43:00 UTC
Created attachment 289428 [details] [review]
undo: Add LayerAdded and LayerRemoved actions.
Comment 12 Thibault Saunier 2014-10-27 15:43:10 UTC
Created attachment 289429 [details] [review]
scenarios: serialize layer addition and removal
Comment 13 Thibault Saunier 2014-10-27 15:43:16 UTC
Created attachment 289430 [details] [review]
scenarios: serialize clip addtion / removal
Comment 14 Thibault Saunier 2014-10-27 15:43:33 UTC
Created attachment 289431 [details] [review]
scenarios: The log file now belongs to the application itself.
Comment 15 Thibault Saunier 2014-10-27 15:43:39 UTC
Created attachment 289432 [details] [review]
scenarios: Serialize play / pause
Comment 16 Thibault Saunier 2014-10-27 15:43:44 UTC
Created attachment 289433 [details] [review]
previewers: hardcoded path manipulations are bad.

And I should feel bad.
Comment 17 Thibault Saunier 2014-10-27 15:43:51 UTC
Created attachment 289434 [details] [review]
scenarios: put scenario files in a cache directory.
Comment 18 Thibault Saunier 2014-10-27 15:43:57 UTC
Created attachment 289435 [details] [review]
utils/timeline: remove unused imports
Comment 19 Thibault Saunier 2014-10-27 15:44:04 UTC
Created attachment 289436 [details] [review]
pitivi: Add a way to let user decide where to save scenario files

Through the PITIVI_SCENARIO_FILE env varible

+ Make sure to state that our scenarios handle state changes
Comment 20 Thibault Saunier 2014-10-27 15:44:09 UTC
Created attachment 289437 [details] [review]
project: Override GES.Timeline.commit to save commit actions

Now scenario have to contain all information about timeline
committing, make sure that the commit action is serialized.
Comment 21 Thibault Saunier 2014-10-27 15:44:16 UTC
Created attachment 289438 [details] [review]
Serialize the start/inpoint/duration of the add-clip action
Comment 22 Thibault Saunier 2014-10-27 15:44:22 UTC
Created attachment 289439 [details] [review]
utils:timeline: Serialize action for container editing
Comment 23 Thibault Saunier 2014-10-27 15:44:30 UTC
Created attachment 289440 [details] [review]
Serialize seek actions and fix state change action serialization
Comment 24 Thibault Saunier 2014-10-27 15:44:38 UTC
Created attachment 289441 [details] [review]
autopep8 WORKS, let's just use it!
Comment 25 Thibault Saunier 2014-10-27 15:44:51 UTC
Created attachment 289442 [details] [review]
Encourage developers to use autopep8
Comment 26 Thibault Saunier 2014-10-27 15:45:00 UTC
Created attachment 289443 [details] [review]
Serialize GES.Clip.split actions
Comment 27 Thibault Saunier 2014-10-27 15:45:08 UTC
Created attachment 289444 [details] [review]
project: Serialize the setting of GES.Track.restriction_caps
Comment 28 Thibault Saunier 2014-10-27 15:45:16 UTC
Created attachment 289445 [details] [review]
Serialize the setting of asset on transition

And simplify the way we write action in the file
Comment 29 Thibault Saunier 2014-10-27 15:45:23 UTC
Created attachment 289446 [details] [review]
application: Add 'wait' action between actions

+ stop everything when quitting.
Comment 30 Thibault Saunier 2014-10-27 15:45:30 UTC
Created attachment 289447 [details] [review]
clipproperties: Commit the timeline when removing an efect

+ No need to flush the pipeline if we already commited (and now
that the commit actually had the same effect)
Comment 31 Thibault Saunier 2014-10-27 15:45:37 UTC
Created attachment 289448 [details] [review]
effect: Serialize effect related actions
Comment 32 Thibault Saunier 2014-10-27 15:45:43 UTC
Created attachment 289449 [details] [review]
undo:timeline: Do not track transitions addition

It is all automatic so we should not let user do or undo their addition
Comment 33 Thibault Saunier 2014-10-27 15:45:52 UTC
Created attachment 289450 [details] [review]
undo: Rename effect related tracker to TrackElement

Because we can track children properties of any TrackElement in there.
Comment 34 Thibault Saunier 2014-10-27 15:45:56 UTC
Created attachment 289451 [details] [review]
undo: Remove the effect.py file and move its content to timeline.py

It is not effect specific anymore, be coherent.
Comment 35 Thibault Saunier 2014-10-27 15:46:01 UTC
Created attachment 289452 [details] [review]
titleeditor: Implement Undo Redo

Keeping things as simple as possible using the
GES.TrackElement.s[g]et_child_property API everywhere.
Comment 36 Thibault Saunier 2014-10-27 15:46:08 UTC
Created attachment 289453 [details] [review]
Fix the testsuite

Minor changes around to fix the testsuite
Comment 37 Thibault Saunier 2014-10-27 15:46:16 UTC
Created attachment 289454 [details] [review]
bin:environment: Do not override user shell preferences
Comment 38 Thibault Saunier 2014-10-27 15:46:26 UTC
Created attachment 289455 [details] [review]
undo: Reimplement undo/redo for Keyframes.
Comment 39 Thibault Saunier 2014-10-27 15:46:36 UTC
Created attachment 289456 [details] [review]
Serialize KeyFrame in the scenario files
Comment 40 Thibault Saunier 2014-10-27 15:46:44 UTC
Created attachment 289457 [details] [review]
project: Factor out a functio to check backup project
Comment 41 Thibault Saunier 2014-10-27 15:46:49 UTC
Created attachment 289458 [details] [review]
mainwindow: Do not use no existing variables
Comment 42 Thibault Saunier 2014-11-15 10:33:00 UTC
This has been merged:

commit 81cf532b252cccc3738763be634eea8a6052986d
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Thu May 1 13:30:11 2014 +0200

    Start implementing scenario serialization
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739251

...

commit 8f78ffd5abf0f505c263499b5749680daba5c913
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Sat Nov 15 11:02:08 2014 +0100

    Rename UndoableAction.serializeLastAction to asScenarioAction