After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739208 - validate-launcher: tool-assisted cleanup and commit hook update.
validate-launcher: tool-assisted cleanup and commit hook update.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 739090
 
 
Reported: 2014-10-26 14:32 UTC by Mathieu Duponchelle
Modified: 2014-11-08 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
validate-launcher: pep8ify sources. (74.28 KB, patch)
2014-10-26 14:34 UTC, Mathieu Duponchelle 		none Details | Review
validate-launcher: baseclasses: fix various pyflakes / uncaught pep8 issues. (4.20 KB, patch)
2014-10-26 14:34 UTC, Mathieu Duponchelle 		none Details | Review
validate-launcher: loggable: fix various pyflakes / uncaught pep8 issues. (3.08 KB, patch)
2014-10-26 14:34 UTC, Mathieu Duponchelle 		none Details | Review
validate-launcher: main: fix various pyflakes / uncaught pep8 issues. (5.76 KB, patch)
2014-10-26 14:34 UTC, Mathieu Duponchelle 		none Details | Review
validate-launcher: utils: fix various pyflakes / uncaught pep8 issues. (676 bytes, patch)
2014-10-26 14:34 UTC, Mathieu Duponchelle 		none Details | Review
apps: gstvalidate.py: fix various pyflakes / uncaught pep8 issues. (5.83 KB, patch)
2014-10-26 14:35 UTC, Mathieu Duponchelle 		none Details | Review
validate: update pre-commit hook. (5.86 KB, patch)
2014-10-26 14:35 UTC, Mathieu Duponchelle 		none Details | Review
validate: update pre-commit hook. (5.86 KB, patch)
2014-10-30 14:40 UTC, Mathieu Duponchelle 		committed Details | Review
apps: gstvalidate.py: fix various pyflakes / uncaught pep8 issues. (5.83 KB, patch)
2014-10-30 14:40 UTC, Mathieu Duponchelle 		committed Details | Review
validate-launcher: utils: fix various pyflakes / uncaught pep8 issues. (676 bytes, patch)
2014-10-30 14:40 UTC, Mathieu Duponchelle 		committed Details | Review
validate-launcher: main: fix various pyflakes / uncaught pep8 issues. (5.76 KB, patch)
2014-10-30 14:40 UTC, Mathieu Duponchelle 		committed Details | Review
validate-launcher: loggable: fix various pyflakes / uncaught pep8 issues. (3.08 KB, patch)
2014-10-30 14:40 UTC, Mathieu Duponchelle 		committed Details | Review
validate-launcher: baseclasses: fix various pyflakes / uncaught pep8 issues. (4.20 KB, patch)
2014-10-30 14:41 UTC, Mathieu Duponchelle 		committed Details | Review
validate-launcher: pep8ify sources. (74.28 KB, patch)
2014-10-30 14:41 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2014-10-26 14:32:35 UTC 
I've run pep8 and pyflakes on the launcher python files, and updated the pre-commit hook to run both the common pre-commit hook and a python pre-commit hook adapted from pitivi's hook, that runs pep8 style checks.
Comment 1 Mathieu Duponchelle 2014-10-26 14:34:41 UTC 
Created attachment 289343 [details] [review]
validate-launcher: pep8ify sources.
Comment 2 Mathieu Duponchelle 2014-10-26 14:34:45 UTC 
Created attachment 289344 [details] [review]
validate-launcher: baseclasses: fix various pyflakes / uncaught pep8 issues.
Comment 3 Mathieu Duponchelle 2014-10-26 14:34:48 UTC 
Created attachment 289345 [details] [review]
validate-launcher: loggable: fix various pyflakes / uncaught pep8 issues.
Comment 4 Mathieu Duponchelle 2014-10-26 14:34:52 UTC 
Created attachment 289346 [details] [review]
validate-launcher: main: fix various pyflakes / uncaught pep8 issues.
Comment 5 Mathieu Duponchelle 2014-10-26 14:34:56 UTC 
Created attachment 289347 [details] [review]
validate-launcher: utils: fix various pyflakes / uncaught pep8 issues.
Comment 6 Mathieu Duponchelle 2014-10-26 14:35:01 UTC 
Created attachment 289348 [details] [review]
apps: gstvalidate.py: fix various pyflakes / uncaught pep8 issues.
Comment 7 Mathieu Duponchelle 2014-10-26 14:35:05 UTC 
Created attachment 289349 [details] [review]
validate: update pre-commit hook.

+ Allows to run multiple pre-commit hooks.
+ Always relink the hooks on autogen.
+ Run pep8 on commited python files.
Comment 8 Mathieu Duponchelle 2014-10-30 14:40:28 UTC 
The following fixes have been pushed:
85587a9 validate: update pre-commit hook.
7bbd3ed apps: gstvalidate.py: fix various pyflakes / uncaught pep8 issues.
9bdc6e9 validate-launcher: utils: fix various pyflakes / uncaught pep8 issues.
b30d27e validate-launcher: main: fix various pyflakes / uncaught pep8 issues.
95065ed validate-launcher: loggable: fix various pyflakes / uncaught pep8 issues.
a0a88e1 validate-launcher: baseclasses: fix various pyflakes / uncaught pep8 issues.
8c1e84b validate-launcher: pep8ify sources.
Comment 9 Mathieu Duponchelle 2014-10-30 14:40:34 UTC 
Created attachment 289671 [details] [review]
validate: update pre-commit hook.

+ Allows to run multiple pre-commit hooks.
+ Always relink the hooks on autogen.
+ Run pep8 on commited python files.
Comment 10 Mathieu Duponchelle 2014-10-30 14:40:38 UTC 
Created attachment 289672 [details] [review]
apps: gstvalidate.py: fix various pyflakes / uncaught pep8 issues.
Comment 11 Mathieu Duponchelle 2014-10-30 14:40:46 UTC 
Created attachment 289673 [details] [review]
validate-launcher: utils: fix various pyflakes / uncaught pep8 issues.
Comment 12 Mathieu Duponchelle 2014-10-30 14:40:53 UTC 
Created attachment 289674 [details] [review]
validate-launcher: main: fix various pyflakes / uncaught pep8 issues.
Comment 13 Mathieu Duponchelle 2014-10-30 14:40:58 UTC 
Created attachment 289675 [details] [review]
validate-launcher: loggable: fix various pyflakes / uncaught pep8 issues.
Comment 14 Mathieu Duponchelle 2014-10-30 14:41:03 UTC 
Created attachment 289676 [details] [review]
validate-launcher: baseclasses: fix various pyflakes / uncaught pep8 issues.
Comment 15 Mathieu Duponchelle 2014-10-30 14:41:08 UTC 
Created attachment 289677 [details] [review]
validate-launcher: pep8ify sources.