After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739091 - validate: launcher: Restructure the folder hierarchy and don't implement product-specific test managers.
validate: launcher: Restructure the folder hierarchy and don't implement prod...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 739090 739093
 
 
Reported: 2014-10-23 19:54 UTC by Mathieu Duponchelle
Modified: 2015-06-24 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
validate-launcher: restructure filesystem (6.96 KB, patch)
2014-10-23 19:58 UTC, Mathieu Duponchelle
accepted-commit_now Details | Review
launcher: Don't implement product-specific TestManagers. (12.07 KB, patch)
2014-10-23 19:58 UTC, Mathieu Duponchelle
reviewed Details | Review
launcher: add a way to specify an application directory. (1.74 KB, patch)
2014-10-23 19:58 UTC, Mathieu Duponchelle
reviewed Details | Review
launcher: add a way to specify an application directory. (1.74 KB, patch)
2014-10-30 14:36 UTC, Mathieu Duponchelle
committed Details | Review
launcher: Don't implement product-specific TestManagers. (12.07 KB, patch)
2014-10-30 14:36 UTC, Mathieu Duponchelle
committed Details | Review
validate-launcher: restructure filesystem (6.96 KB, patch)
2014-10-30 14:37 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2014-10-23 19:54:30 UTC
It should be up to the products that need to be validated to implement test managers, and possibly distribute them alongside the default test manager.
Comment 1 Mathieu Duponchelle 2014-10-23 19:58:19 UTC
Created attachment 289229 [details] [review]
validate-launcher: restructure filesystem
Comment 2 Mathieu Duponchelle 2014-10-23 19:58:25 UTC
Created attachment 289230 [details] [review]
launcher: Don't implement product-specific TestManagers.

This manager will be moved in GES.
Comment 3 Mathieu Duponchelle 2014-10-23 19:58:30 UTC
Created attachment 289231 [details] [review]
launcher: add a way to specify an application directory.
Comment 4 Thibault Saunier 2014-10-24 07:37:31 UTC
Review of attachment 289229 [details] [review]:

Is it me or you just did not actually moved the file but did has it was done in the build system?
Comment 5 Thibault Saunier 2014-10-24 07:37:48 UTC
Review of attachment 289230 [details] [review]:

OK
Comment 6 Thibault Saunier 2014-10-24 07:38:46 UTC
Review of attachment 289231 [details] [review]:

OK
Comment 7 Mathieu Duponchelle 2014-10-24 09:26:17 UTC
(In reply to comment #4)
> Review of attachment 289229 [details] [review]:
> 
> Is it me or you just did not actually moved the file but did has it was done in
> the build system?

I'm gonna assume I understood that question :P

It indeed doesn't show up in a "review" but if you look at the actual patch you'll see renames
Comment 8 Thibault Saunier 2014-10-24 09:33:17 UTC
Review of attachment 289229 [details] [review]:

OK, weird we do not see the renaming in here, anyway. Good then.
Comment 9 Mathieu Duponchelle 2014-10-30 14:35:03 UTC
The following fixes have been pushed:
Comment 10 Mathieu Duponchelle 2014-10-30 14:36:47 UTC
The following fixes have been pushed:
4d569b5 launcher: add a way to specify an application directory.
74ed40c launcher: Don't implement product-specific TestManagers.
b0beefa validate-launcher: restructure filesystem
Comment 11 Mathieu Duponchelle 2014-10-30 14:36:51 UTC
Created attachment 289668 [details] [review]
launcher: add a way to specify an application directory.
Comment 12 Mathieu Duponchelle 2014-10-30 14:36:56 UTC
Created attachment 289669 [details] [review]
launcher: Don't implement product-specific TestManagers.

This manager will be moved in GES.
Comment 13 Mathieu Duponchelle 2014-10-30 14:37:04 UTC
Created attachment 289670 [details] [review]
validate-launcher: restructure filesystem