After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739079 - SET_PACKAGE_RELEASE_DATETIME fails to evaluate YYYY-MM-DD param
SET_PACKAGE_RELEASE_DATETIME fails to evaluate YYYY-MM-DD param
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other All
: Normal minor
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-23 14:41 UTC by pudbou+gst
Modified: 2015-10-31 12:43 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
set of 3 patches fixing the issue (4.04 KB, patch)
2014-10-23 14:41 UTC, pudbou+gst 		committed Details | Review

Description pudbou+gst 2014-10-23 14:41:07 UTC 
Created attachment 289211 [details] [review]
set of 3 patches fixing the issue

There are 2 issues:
1) the grep patterns conflicts with M4 quotes 
2) the 2 parameters invocation AG_GST_SET_PACKAGE_RELEASE_DATETIME([yes], ["YYYY-MM-DD"]) uses the first parameter in the grep pattern instead of the second.

Moreover some comments does not reflect what the macro is supposed to do.
Comment 1 Tim-Philipp Müller 2015-10-31 12:43:26 UTC 
Thanks for the patches!

commit b05b9cb537caadd9e34039037fe833b9d858fb9f
Author: Sylvain Etienne <pudbou@gmail.com>
Date:   Thu Oct 23 15:45:34 2014 +0200

    m4: bad parameter use in SET_PACKAGE_RELEASE_DATETIME
    
    the 2-parameter invocation:
    AG_GST_SET_PACKAGE_RELEASE_DATETIME([yes], [YYYY-MM-DD])
    is greping the first parameter instead of the second.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739079

commit 5afa1af9cf776a9ddf705ab3283c0df2d71e5ef7
Author: Sylvain Etienne <pudbou@gmail.com>
Date:   Thu Oct 23 15:39:37 2014 +0200

    m4: grep's RE patterns conflict with M4 quotes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739079

commit 580d6b097fe9c7dd3e5f18329683e8e13b948e1f
Author: Sylvain Etienne <pudbou@gmail.com>
Date:   Thu Oct 23 15:52:13 2014 +0200

    m4: fix comments of SET_PACKAGE_RELEASE_DATETIME
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739079