GNOME Bugzilla – Bug 738970
Warning msg when ~/.profile syntax error instead of failed login
Last modified: 2018-02-12 15:05:07 UTC
This is a forward of https://launchpad.net/bugs/678421 in Ubuntu. In case of a syntax error in ~/.profile or some similar config file, the login is interrupted and you are taken back to the login screen. If there is some other kind of error, it's silently ignored. We are about to make lightdm show a warning dialog for all kinds of errors in those files, and at the same time allow the login to the desktop to proceed. We believe that the feature should be useful for gdm too.
Created attachment 289088 [details] [review] Config error dialog for Xsession The attached patch is based on gdm 3.10.0.1, which we are currently using in Ubuntu, but I have a feeling that it would apply just fine on the master branch as well.
Hello Gunnar, I confirm this bug which is not so easy to debug! It's just a detail but I'm wondering why you added this line at the beginning of config-error-dialog.sh if you're not working for Canonical :-) Copyright (C) 2014 Canonical Ltd
Den 2014-10-22 00:44, Matthieu Baerts skrev: > It's just a detail but I'm wondering why you added this line at the > beginning of config-error-dialog.sh if you're not working for > Canonical :-) > > Copyright (C) 2014 Canonical Ltd Because I wrote it originally for lightdm, of which Canonical is the copyright holder. No big deal to me.
Created attachment 291489 [details] [review] Config error dialog for Xsession II Adding a modified patch with an improved solution, similar to the current solution in the lightdm equivalent. It includes a proposed change of $XSESSION_SHELL from /bin/sh to /bin/bash. Bash has a built-in syntax check when sourcing files. The new patch is based on gdm 3.14.0.
pretty sure we don't want this. It's just not a good user experience. (granted failing to log in isn't a good user experience either, but this isn't better).