After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738942 - moving the stylesheet to gresource broke "reload theme"
moving the stylesheet to gresource broke "reload theme"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-21 13:46 UTC by Jakub Steiner
Modified: 2015-10-21 23:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
runDialog: Reload resource on 'rt' (2.12 KB, patch)
2015-10-21 17:33 UTC, Florian Müllner
committed Details | Review

Description Jakub Steiner 2014-10-21 13:46:14 UTC
'rt' in looking glass no longer reloads the theme, since it was moved to the gresource. Either we should have this working or remove the functionality.
Comment 1 zagortenay333 2015-10-17 19:32:58 UTC
(In reply to Jakub Steiner from comment #0)
> 'rt' in looking glass no longer reloads the theme, since it was moved to the
> gresource. Either we should have this working or remove the functionality.

Please don't remove. It is extremely useful when developing themes. :/
Comment 2 Jakub Steiner 2015-10-21 16:56:42 UTC
Making it work is probably the better alternative as reloading shell no longer works in a Wayland session.
Comment 3 Florian Müllner 2015-10-21 17:33:39 UTC
Created attachment 313820 [details] [review]
runDialog: Reload resource on 'rt'

Moving the default theme to a resource broke the 'rt' command;
reload the resource before the theme to fix it.
Comment 4 Rui Matos 2015-10-21 18:06:25 UTC
Review of attachment 313820 [details] [review]:

lgtm
Comment 5 Florian Müllner 2015-10-21 18:55:24 UTC
Attachment 313820 [details] pushed as 0b9e68e - runDialog: Reload resource on 'rt'
Comment 6 alex diavatis 2015-10-21 22:43:51 UTC
It doesn't belong here, but since you mentioned Shell Restart. 
Because "r" isn't working on Wayland, it is not possible to unload extensions without logging off.

Will "r" work at some point on Wayland?
Comment 7 Florian Müllner 2015-10-21 23:40:05 UTC
(In reply to alex diavatis from comment #6) 
> Because "r" isn't working on Wayland

It's not that it's not working, it has been disabled on purpose. That's because when using wayland, the shell is the display server, and apps don't generally deal with the display server going away - in other words, restarting the shell under wayland has the side effect of all windows going away, see bug 741665.
So no, while we cannot expect apps to deal with a restart of the display server, "r" will remain disabled.