After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738937 - Code convention fixes
Code convention fixes
Status: RESOLVED FIXED
Product: swell-foop
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: swell-foop-maint
swell-foop-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-21 13:20 UTC by Sahil Sareen
Modified: 2014-11-01 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Code cleanup as per gnome coding conventions (4.01 KB, patch)
2014-10-21 13:20 UTC, Sahil Sareen 		reviewed Details | Review
Code cleanup as per gnome coding conventions (4.36 KB, patch)
2014-11-01 08:14 UTC, Sahil Sareen 		committed Details | Review

Description Sahil Sareen 2014-10-21 13:20:25 UTC 
Created attachment 289037 [details] [review]
Code cleanup as per gnome coding conventions

Code cleanup as per gnome coding conventions
Comment 1 Michael Catanzaro 2014-10-21 23:34:51 UTC 
Review of attachment 289037 [details] [review]:

There's different styles for casting, but we normally leave a space between the cast and the variable, like (int) data rather than (int)data.  Judging from the diff, that's the more common style in Swell Foop as well.  (But if not, then what you did is fine.)
Comment 2 Sahil Sareen 2014-10-22 04:32:14 UTC 
I'll do that.
Comment 3 Sahil Sareen 2014-11-01 08:14:01 UTC 
Created attachment 289770 [details] [review]
Code cleanup as per gnome coding conventions

+Fixed review comments[ use "(type) data" instead of "(type)data" ]
Comment 4 Michael Catanzaro 2014-11-01 13:49:52 UTC 
Thanks!