After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738893 - ComboBox in appears-as-list mode: Finishing scroll with mouse causes menu to pop down
ComboBox in appears-as-list mode: Finishing scroll with mouse causes menu to ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
3.22.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
app
Depends on:
Blocks:
 
 
Reported: 2014-10-20 19:14 UTC by Jim
Modified: 2017-09-04 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ComboBox: Don’t popdown if releasing on scrollbar (1.75 KB, patch)
2017-09-04 22:49 UTC, Daniel Boles
committed Details | Review

Description Jim 2014-10-20 19:14:11 UTC
GtkCombobox with "appears-as-list" Gth+ 3.14.1
Click on "Down Arrow" to bring up list and scrollbar
Move the scroll-bar down with the mouse - release mouse button and list collapses.
The only way is to scroll-down until the required entry is visible in the list and move the mouse cursor to the (left) into the list and over the required entry and then release the mouse button.
This does, of course, mean 1 less mouse click but it is not an easy way to work.
Comment 1 Robby Workman 2014-10-23 05:12:25 UTC
Is this the same (or related) bug? https://bugzilla.redhat.com/show_bug.cgi?id=1149335
Comment 2 Jim 2014-10-23 10:08:03 UTC
I really can't tell if it is related - I can't understand the description of the problem in redhat (what icon, what menu?) and I don't know the internals of how the GtkCombobox with "appears-as-list" relates to the problem described in that bug.
In addition this problem is new in Gtk 3.14 - it has worked fine until a few days ago.
Comment 3 Daniel Boles 2017-08-24 22:46:47 UTC
general observation: There are various problems with appears-as-list, many of which concern mouse input/release.
Comment 4 Daniel Boles 2017-09-04 22:46:01 UTC
Confirmed. This happens on any button release within the popup ScrolledWindow, including after clicking to page/warp, or when releasing a drag of the scrollbar.

Should be trivial to fix - patch imminent.
Comment 5 Daniel Boles 2017-09-04 22:49:53 UTC
Created attachment 359123 [details] [review]
ComboBox: Don’t popdown if releasing on scrollbar

On button release, we were popping down if the event widget was anything
but priv->button. This broke scrolling by clicking a mouse button, i.e.
when releasing a click in the trough or finishing a drag of either bar.
That’s unexpected, inconvenient, and pointless, so let’s stop doing it.

--

While this works – and does not seem capable of breaking anything* –
testing it revealed a pre-existing problem to me:

If you start a drag on the Scrollbar, then move back to the TreeView proper,
then release over the latter, you get this:

> Gtk-CRITICAL **: gtk_css_gadget_queue_allocate: assertion 'GTK_IS_CSS_GADGET (gadget)' failed

Backtrace impending.

Still, at least this patch doesn’t make anything /worse/!*


*he says with hopeless optimism
Comment 6 Daniel Boles 2017-09-04 22:59:41 UTC
(In reply to Daniel Boles from comment #5)
> If you start a drag on the Scrollbar, then move back to the TreeView proper,
> then release over the latter, you get this:
> 
> > Gtk-CRITICAL **: gtk_css_gadget_queue_allocate: assertion 'GTK_IS_CSS_GADGET (gadget)' failed
> 
> Backtrace impending.

That happens any time you release and cause the CB to popdown, when the Scrollbar was fully shown due to having started a drag. Filed as Bug 787274
Comment 7 Daniel Boles 2017-09-04 23:14:50 UTC
Attachment 359123 [details] pushed as 99e27ab - ComboBox: Don’t popdown if releasing on scrollbar