After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738885 - Code fix as per the gnome coding conventions
Code fix as per the gnome coding conventions
Status: RESOLVED FIXED
Product: tali
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Tali maintainer(s)
Tali maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-20 17:32 UTC by Sahil Sareen
Modified: 2014-10-21 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Coding guidelines fixes (32.08 KB, patch)
2014-10-20 17:32 UTC, Sahil Sareen 		reviewed Details | Review
Fixed Michael's review comments (31.85 KB, patch)
2014-10-21 05:04 UTC, Sahil Sareen 		committed Details | Review

Description Sahil Sareen 2014-10-20 17:32:05 UTC 
Created attachment 288971 [details] [review]
Coding guidelines fixes

As discussed with Michael over the IRC, tali code being pretty old needed some cleanup.
Comment 1 Michael Catanzaro 2014-10-20 21:34:52 UTC 
Review of attachment 288971 [details] [review]:

Thanks!

::: src/clist.c
@@ +187,2 @@
   /* Quoted from docs: "The returned GtkTreePath must be freed 
+   * with gtk_tree_path_free () when you are done with it." */

Except after the name of a function in a comment, you really don't want the extra space. Hope that's sufficiently confusing. :p

::: src/computer.c
@@ +275,1 @@
               best, bc_table[best], _(FieldLabels[best]));

Here, move the following line over one space as well.
Comment 2 Sahil Sareen 2014-10-21 05:04:46 UTC 
Created attachment 289003 [details] [review]
Fixed Michael's review comments

Tali code cleanup.