After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738883 - afc: goa: Clean up
afc: goa: Clean up
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-20 17:29 UTC by Debarshi Ray
Modified: 2014-10-21 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afc: Clean up (1.14 KB, patch)
2014-10-20 17:31 UTC, Debarshi Ray 		committed Details | Review
goa: Clean up (1.10 KB, patch)
2014-10-20 17:32 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-10-20 17:29:36 UTC 
No need to repeat things that g_vfs_proxy_volume_monitor_daemon_init already does for us.
Comment 1 Debarshi Ray 2014-10-20 17:31:44 UTC 
Created attachment 288970 [details] [review]
afc: Clean up
Comment 2 Debarshi Ray 2014-10-20 17:32:07 UTC 
Created attachment 288972 [details] [review]
goa: Clean up
Comment 3 Ondrej Holy 2014-10-21 07:27:02 UTC 
Review of attachment 288970 [details] [review]:

It looks good, thanks...

::: monitor/afc/afcvolumemonitordaemon.c
@@ +8,1 @@
 #include <config.h>

Also this header could be removed, however it is included in other files, where it isn't necessary, therefor it is ok probably...
Comment 4 Ondrej Holy 2014-10-21 07:27:19 UTC 
Review of attachment 288972 [details] [review]:

dtto
Comment 5 Debarshi Ray 2014-10-21 09:36:07 UTC 
Thanks, Ondrej!