After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738879 - Updated Lua's syntax rules.
Updated Lua's syntax rules.
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-20 17:01 UTC by Kate Adams
Modified: 2014-10-20 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch. (8.52 KB, patch)
2014-10-20 17:01 UTC, Kate Adams 		none Details | Review

Description Kate Adams 2014-10-20 17:01:05 UTC 
Created attachment 288968 [details] [review]
Patch.

Added goto keyword.
Added support for the label syntax (`::name::`).
Updated the global functions to Lua 5.2, and added metamethods.
Comment 1 Sébastien Wilmet 2014-10-20 17:18:24 UTC 
Pushed:
https://git.gnome.org/browse/gtksourceview/commit/?id=c5c9d8cccb34adee8bd2f126737cf3a3cb33a0cd
https://git.gnome.org/browse/gtksourceview/commit/?id=d4f3d9ca1d6c0b2a5de6f52c646f20ae8f109599

A few comments for the next time:
- attach separate patches as separate attachments, it's clearer.
- avoid trailing spaces, and to separate sections, add only one blank line, not two.
- the first line of the commit message should be short (<= 72 characters).

Apart from that, the patches look good, but I know nothing about Lua, so I trust you to not have screwed things up.

Thanks!