GNOME Bugzilla – Bug 738865
Buttons in save password bar have different vertical size
Last modified: 2015-02-03 15:20:45 UTC
Created attachment 288937 [details] Screenshot See the attached screenshot. The "save" and "x" buttons have different vertical sizes. Using a vertical size group might be helpful.
Created attachment 293984 [details] screenshot of fix I post a screenshot of the fix because the close button is a bit big.
Created attachment 293985 [details] [review] GtkInfoBar: Put the action area and close button in a vertical size group
Review of attachment 293985 [details] [review]: That looks perfect except I noticed the commit message exceeding 72 character limit as according to here : https://wiki.gnome.org/Git/CommitMessages
Created attachment 294040 [details] [review] GtkInfoBar: Put action area and close button in vertical size group
I don't really agree that it looks perfect - the button is too big now for the small icon. I would suggest that you are better off hiding the image button and showing a [ Save ][ Close ] if the extra close button is really necessary.
OK. That might be good to mention in the API docs, since I thought this was how it was intended to be used.
Created attachment 294135 [details] [review] Add missing mnemonic to save password infobar
Created attachment 294136 [details] [review] Use a text button for Close on the save password info bar The standard close image button looks bad next to a text button.
I thought to put the Close button to the left of the Save button, like we do for message dialogs, but it felt out of place.
Created attachment 294238 [details] [review] Use a Don't Save button on the save password info bar The standard close image button looks bad next to a text button.
Review of attachment 294238 [details] [review]: Ok
Attachment 294135 [details] pushed as 4b2a1f0 - Add missing mnemonic to save password infobar Attachment 294238 [details] pushed as a0d0cf8 - Use a Don't Save button on the save password info bar