After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738849 - Propgate key-press events to view actor
Propgate key-press events to view actor
Status: RESOLVED FIXED
Product: libchamplain
Classification: Core
Component: gtk-embed
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libchamplain-maint
libchamplain-maint
Depends on:
Blocks: 737774
 
 
Reported: 2014-10-20 09:16 UTC by Jonas Danielsson
Modified: 2014-10-20 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkChamplainEmbed: Propagate key-press to view (2.79 KB, patch)
2014-10-20 09:16 UTC, Jonas Danielsson 		none Details | Review
ChamplainView: Move the key-press event to view (2.30 KB, patch)
2014-10-20 09:17 UTC, Jonas Danielsson 		committed Details | Review
GtkChamplainEmbed: Propagate key-press to view (2.56 KB, patch)
2014-10-20 09:19 UTC, Jonas Danielsson 		none Details | Review
GtkChamplainEmbed: Propagate key-press to view (2.61 KB, patch)
2014-10-20 12:19 UTC, Jonas Danielsson 		committed Details | Review

Description Jonas Danielsson 2014-10-20 09:16:22 UTC 
Hi,

Lets try to propagate the key-press events from a GtkChamplainEmbed to the ChamplainView actor. So that GTK application can pan/zoom using keyboard.
Comment 1 Jonas Danielsson 2014-10-20 09:16:56 UTC 
Created attachment 288899 [details] [review]
GtkChamplainEmbed: Propagate key-press to view

Make sure the GtkChamplainEmbed widget gives focus to the
GtkClutterEmbed widget. And also propagates the key press
events to the ChamplainView actor.
Comment 2 Jonas Danielsson 2014-10-20 09:17:01 UTC 
Created attachment 288900 [details] [review]
ChamplainView: Move the key-press event to view

Bind the key-press event to the view actor instead
of the kinetic_scroll actor. This will allow users
of GtkChamplainEmbed to use the pan and zoom bindings
from their application.
Comment 3 Jonas Danielsson 2014-10-20 09:19:55 UTC 
Created attachment 288902 [details] [review]
GtkChamplainEmbed: Propagate key-press to view

Make sure the GtkChamplainEmbed widget gives focus to the
GtkClutterEmbed widget. And also propagates the key press
events to the ChamplainView actor.
Comment 4 Jonas Danielsson 2014-10-20 12:19:13 UTC 
Created attachment 288924 [details] [review]
GtkChamplainEmbed: Propagate key-press to view

Make sure the GtkChamplainEmbed widget gives focus to the
GtkClutterEmbed widget. And also propagates the key press
events to the ChamplainView actor.
Comment 5 Jiri Techet 2014-10-20 18:09:52 UTC 
Review of attachment 288900 [details] [review]:

LGTM
Comment 6 Jiri Techet 2014-10-20 18:10:24 UTC 
Review of attachment 288924 [details] [review]:

LGTM
Comment 7 Jiri Techet 2014-10-20 18:10:51 UTC 
I have suspected there was a way to propagate the events - was just a bit lazy to investigate. Thanks for looking into this.