After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738792 - Regression: OSX gtk+3 patch broke Linux by forcing objective-c compilation on files that don't need it
Regression: OSX gtk+3 patch broke Linux by forcing objective-c compilation on...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-18 21:00 UTC by Brion Vibber
Modified: 2014-10-19 18:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
only apply objc compilation hack patch on Mac OS X (1.42 KB, patch)
2014-10-18 21:00 UTC, Brion Vibber 		none Details | Review
one-char fix to the patch to avoid breaking other recipes (whoops) (1.42 KB, patch)
2014-10-19 16:20 UTC, Brion Vibber 		committed Details | Review

Description Brion Vibber 2014-10-18 21:00:39 UTC 
Created attachment 288826 [details] [review]
only apply objc compilation hack patch on Mac OS X

Patch in commit 6cd33e9e79 for gtk+3 recipe forces objective-c compilation on GDK input modules; while this fixes the build for imquartz.c on Mac OS X it breaks other modules on Linux if an Objective-C compiler isn't installed.

The patch should only be applied if building for Platform.DARWIN; see attached patch.
Comment 1 Brion Vibber 2014-10-19 16:20:52 UTC 
Created attachment 288853 [details] [review]
one-char fix to the patch to avoid breaking other recipes (whoops)
Comment 2 Sebastian Dröge (slomo) 2014-10-19 18:04:17 UTC 
commit eabf48161dde47982934081938268c28cc7471aa
Author: Brion Vibber <brion@pobox.com>
Date:   Sat Oct 18 13:53:10 2014 -0700

    gtk+3: Only apply objective-c compilation hack patch on Mac OS X
    
    Otherwise gtk+3 compilation fails on Linux if objective-c
    compiler is not available.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738792