After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738772 - Remove the use of deprecated properties
Remove the use of deprecated properties
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-18 17:11 UTC by Dominique Leuenberger
Modified: 2014-11-14 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove the use of deprecated properties (2.21 KB, patch)
2014-10-18 17:11 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2014-10-18 17:11:21 UTC 
/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_startup.py:138: Warning: The property GtkWidget:margin-left is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.props.margin_left = 1

/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_startup.py:139: Warning: The property GtkWidget:margin-right is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.props.margin_right = 1

/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_startup.py:155: Warning: The property GtkSettings:gtk-button-images is deprecated and shouldn't be used anymore. It will be removed in a future version.

Having gnome-tweak-tools cleaned up from this will still report two warnings on startup, but they are in pygobject 3.14.x
Comment 1 Dominique Leuenberger 2014-10-18 17:11:23 UTC 
Created attachment 288818 [details] [review]
Remove the use of deprecated properties

/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_startup.py:138:
Warning: The property GtkWidget:margin-left is deprecated and shouldn't
be used anymore. It will be removed in a future version.
  self.props.margin_left = 1

/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_startup.py:139:
Warning: The property GtkWidget:margin-right is deprecated and shouldn't
be used anymore. It will be removed in a future version.
  self.props.margin_right = 1

/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_startup.py:155:
Warning: The property GtkSettings:gtk-button-images is deprecated and
shouldn't be used anymore. It will be removed in a future version.
Comment 2 Rui Matos 2014-11-14 16:18:09 UTC 
Review of attachment 288818 [details] [review]:

Looks fine, thanks

::: gtweak/tweaks/tweak_group_startup.py
@@ +155,1 @@
         self.btn.props.always_show_image = True

To actually avoid the warning we need to pass always_show_image=True to the constructor. I'll massage the patch to do that locally before pushing
Comment 3 Rui Matos 2014-11-14 16:19:57 UTC 
Attachment 288818 [details] pushed as f3878f2 - Remove the use of deprecated properties