After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738734 - support gtkflowbox
support gtkflowbox
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
: 751869 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-10-18 03:06 UTC by Matthias Clasen
Modified: 2015-12-21 03:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2014-10-18 03:06:25 UTC
I've pushed a flowbox branch which has the necessary code.
Comment 1 Matthias Clasen 2015-11-18 18:45:16 UTC
I've rebased the branch to current master. It still works fine.
Comment 2 Matthias Clasen 2015-12-11 23:34:41 UTC
*** Bug 751869 has been marked as a duplicate of this bug. ***
Comment 3 Tristan Van Berkom 2015-12-21 03:39:11 UTC
After looking at your branch, I made a couple changes:

  o Removed duplicate declaration of displayable values for
    GtkSelectionMode, these were already declared by GtkListBox

    Explanation: The enum type displayable values should really
    be parsed before all the widget types, it's something we never
    got around to.

    So instead, the first widget class which uses an enumeration
    or flags type property is responsible for declaring the
    translatable displayable values for that type.

    Note that Glade issues helpful warnings on the console so
    that you can catch these errors in development, they look like:

    GladeUI-WARNING **: Already registered displayable value Start for start (type GtkPackType)


  o Removed duplicate declaration of GtkListBoxRow (note there is also
    a warning issued by Glade at startup time to help you catch this).


There is also a minor undo/redo related bug which occurs consistently when using the "Insert Before" packing action (which is only accessible when right clicking on the GtkFlowBoxChild in the Inspector view).

The GtkListBox implementation shares this flaw, and I have filed that as bug 759715.

The basic functionality is good, merged.