GNOME Bugzilla – Bug 738722
rtpmux returns EMPTY caps when query'ing
Last modified: 2014-10-24 19:55:45 UTC
Created attachment 288788 [details] [review]
When XMPP calls with empathy outgoing audio calls fail due to nicesink failing to be linked to the rtp muxer as it returns EMPTY when querying caps as it tries to give the result of intersecting incompatible caps (dtmfsrc & the audio stream)
Review of attachment 288788 [details] [review]:
Looks good, also it should probably go into the 1.4 branch
Author: Sjoerd Simons <firstname.lastname@example.org>
Date: Fri Oct 17 22:23:27 2014 +0200
rtpmux: Don't set PROXY_CAPS flag on the src pad
rtpmux behaves like a funnel in that it forwards whatever upstream is
sending buffers. So setting proxy caps doesn't make sense as the
upstream don't have to have compatible caps, thus resulting in an empty
caps set as a result of a caps query. Instead set fixed caps just
as funnel does.
Cherry-picked into 1.4 branch as well.