GNOME Bugzilla – Bug 738608
hlssink: Add URI handler interface
Last modified: 2018-11-03 13:27:52 UTC
Created attachment 288651 [details] [review] HLS uri handler This patch adds a uri-handler to hlssink. Greetings from Dusseldorf; Tim just complained there were not enough bugs and companies were not contributing enough :-)
Created attachment 288655 [details] [review] location is set from the path of the uri
Review of attachment 288651 [details] [review]: Aside the naming issues we need to decide if we want another custom scheme into gstreamer. We already have v4l2 for example, but that was because there was no way to inject a non uri handler element into it. What's the use case here? ::: configure.ac @@ +3000,3 @@ + PKG_CHECK_MODULES(SOUP2, libsoup-2.4 >= 2.38.1, HAVE_SOUP2="yes", [ + HAVE_SOUP2="no" + ]) I'm concerned whether this would end up disabling hls support in non-linux platforms. Is libsoup easily instalable? ::: ext/hls/gsthlssink.c @@ +90,3 @@ gst_hls_sink_change_state (GstElement * element, GstStateChange trans); static gboolean schedule_next_key_unit (GstHlsSink * sink); +static void gst_barco_parse_uri (GObject * obj, SoupURI * uri); Cool name but I guess it wasn't intentional @@ +606,3 @@ + +static gboolean + Same naming issue here @@ +623,3 @@ + +static void + return TRUE; And here
Review of attachment 288651 [details] [review]: Considering soup; as far as I noticed; it is being used in other modules too and I know that soup, it is also working on Windows. This sort of parsing is what we typically do and the modules are running on Windows and Linux. The naming issue is indeed not something intentional; it was a piece of code that was taken out another (internal) module to do the parsing. I will change that.
libsoup works everywhere, but I would prefer if we could just use GstUri from core for that :) We have URI handling capabilities in git master now.
I am all in favour to move to GstUri; but it can only be done in 1.6 as far as I understand.
Yes, all patches are going to be merged into master only anyway... and only bugfixes (no feature additions like this) would be backported to 1.4. So no problem here
Created attachment 300297 [details] [review] rewrite to GstUri Written against 1.4.5 GstUri from git master.
ah yeah, the g_hash_table_destroy needs to be g_hash_table_unref
Created attachment 347630 [details] [review] Add GstUri interface to hls
Another URI handler for a sink ? Really ?
Created attachment 347840 [details] [review] rework
Review of attachment 347840 [details] [review]: ::: ext/hls/gsthlssink.c @@ +453,3 @@ + gchar *string = gst_uri_to_string (sink->uri); + + g_value_set_string (value, string); Use g_value_take_string()
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/183.