After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738588 - [review] dcbw/unmanaged-available: fix activating default-unmanaged devices
[review] dcbw/unmanaged-available: fix activating default-unmanaged devices
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-15 18:17 UTC by Dan Williams
Modified: 2014-11-07 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Williams 2014-10-15 18:17:54 UTC
default-unmanaged devices are unmanaged until the user explicitly activates them.  Unfortunately that was broken because no connections were in AvailableConnections for these devices.

Next, shared connections were excluded from master device ignore carrier checks, which is wrong because they are effectively static/manual connections for the master device.  Furthermore, because bridge/bond don't get a carrier until at least one of their slaves have a carrier, this meant that shared IP configuration was not applied to a bridge/bond with tun/tap/veth slaves (a common VM/container configuration such as the libvirt default) until a container/VM was started and attached to the tun/tap/veth (which only turn on the carrier when something is attached), which could be too late.  Allow shared configurations to be started immediately on master devices, ignoring carrier state.
Comment 1 Thomas Haller 2014-10-23 12:25:06 UTC
Looks good to me
Comment 2 Dan Winship 2014-10-23 13:33:25 UTC
me too
Comment 3 Dan Williams 2014-10-23 20:38:29 UTC
One additional patch for review.  The others are unchanged:

core: autoconnect fixes for default-unmanaged devices and property notification

the previous patches allowed default-unmanaged devices to be autoconnected, which this patch fixes.
Comment 4 Jiri Klimes 2014-10-24 08:03:44 UTC
The branch seems fine to me.
Comment 5 Dan Winship 2014-10-24 14:12:19 UTC
>+ * nm_device_get_autoconnect:
>+ * @self: the #NMDevice
>+ *
>+ * Returns: %TRUE if the device is explicitly blocking all autoconnect

%FALSE

otherwise looks good
Comment 6 Dan Williams 2014-10-27 18:45:37 UTC
(In reply to comment #5)
> >+ * nm_device_get_autoconnect:
> >+ * @self: the #NMDevice
> >+ *
> >+ * Returns: %TRUE if the device is explicitly blocking all autoconnect
> 
> %FALSE
> 
> otherwise looks good

Fixed and merged to git master.