GNOME Bugzilla – Bug 738581
Build openh264 and librstp plugins in gst-plugins-bad-1.0{,-static}.recipe
Last modified: 2014-10-21 10:17:31 UTC
The attached patches add new recipes and fix librsvg's build. List of new recipes: openssl, libsrtp, openh264, vala-m4, gobject-introspection-m4 (similar to gettext-m4, and for the same reason -- needed to autoreconf librsvg).
*** Bug 738582 has been marked as a duplicate of this bug. ***
Created attachment 288595 [details] [review] New openssl.recipe
Created attachment 288596 [details] [review] New libsrtp.recipe
Created attachment 288597 [details] [review] glib.recipe: Include glib-gettext.m4 in devel files
Created attachment 288598 [details] [review] New recipe: vala-m4.recipe
Created attachment 288599 [details] [review] New recipe: gobject-introspection-m4.recipe
Created attachment 288600 [details] [review] librsvg: Fix automagic gtk+ support, and add missing gdk-pixbuf dep
Created attachment 288602 [details] [review] New recipe: openh264.recipe
Created attachment 288603 [details] [review] gst-plugins-bad-1.0: Add srtp and openh264 plugins
Just one question.. how is the OpenSSL threading initialized here? Is it the app's responsability ?
(In reply to comment #12) > Just one question.. how is the OpenSSL threading initialized here? Is it the > app's responsability ? The build leaves the threading support in openssl to default, which is that it's enabled. What that actually implies for an application using it, in this case libsrtp, is upto the srtp plugin. :)
Review of attachment 288600 [details] [review]: ::: recipes/librsvg.recipe @@ +18,3 @@ 'lib/librsvg-2.a', 'lib/librsvg-2.la'] files_typelibs = ['Rsvg-2.0'] + configure_options = ' --disable-pixbuf-loader --without-gtk3 ' I think you should check if the gtk3 variant is enabled first no?
Created attachment 288656 [details] [review] librsvg: Fix automagic gtk+ support, and add missing gdk-pixbuf dep (In reply to comment #14) > Review of attachment 288600 [details] [review]: > > ::: recipes/librsvg.recipe > @@ +18,3 @@ > 'lib/librsvg-2.a', 'lib/librsvg-2.la'] > files_typelibs = ['Rsvg-2.0'] > + configure_options = ' --disable-pixbuf-loader --without-gtk3 ' > > I think you should check if the gtk3 variant is enabled first no? --with-gtk3 just enables building of the `rsvg-view-3` binary, which is mostly useless for cerbero, so I disabled it to avoid a gtk3 dependency while building gst-plugins-bad. The attached patch adds a comment to that effect.