After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738558 - Logic reversed when responding to click vs grab on titlebar when raise-on-click is false
Logic reversed when responding to click vs grab on titlebar when raise-on-cli...
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-15 03:27 UTC by Adam Goode
Modified: 2014-10-15 05:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Adam Goode 2014-10-15 03:27:58 UTC
src/core/display.c line 1968 is missing a ! that was accidentally lost in a cleanup.

I've confirmed this fixes the problem for me.


diff --git a/src/core/display.c b/src/core/display.c
index 4669593..185452b 100644
--- a/src/core/display.c
+++ b/src/core/display.c
@@ -1965,7 +1965,7 @@ meta_display_end_grab_op (MetaDisplay *display,
        * beginning of the grab_op.
        */
       if (!meta_prefs_get_raise_on_click () &&
-          display->grab_threshold_movement_reached)
+          !display->grab_threshold_movement_reached)
         meta_window_raise (display->grab_window);
 
       meta_window_grab_op_ended (grab_window, grab_op);
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-10-15 05:30:02 UTC
https://git.gnome.org/browse/mutter/commit/?id=34516aeab6a60896a4c4df2575bb8790c0e8dd21

Thanks for the report and patch. I don't test raise-on-click very often, as you might be able to tell!