After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738532 - vc1parse: select caps according to wmv format at negotiation
vc1parse: select caps according to wmv format at negotiation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-14 14:20 UTC by Aurélien Zanelli
Modified: 2014-10-25 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vc1parse: select caps according to wmv format at negotiation (3.60 KB, patch)
2014-10-14 14:21 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-10-14 14:20:21 UTC 
My hardware decoder can decode both WMV3 and WVC1, but it request different header-format/stream-format for each WMV format. So my decoder caps are basically:
video/x-wmv
                 format: WVC1
          stream-format: bdu
                  width: [ 1, 2147483647 ]
                 height: [ 1, 2147483647 ]
      video/x-wmv
                 format: WMV3
          header-format: sequence-layer-raw-frame
                  width: [ 1, 2147483647 ]
                 height: [ 1, 2147483647 ]

But currently, when we negotiate the output format in vc1parse element, it keeps the first structure regardless of the format.
Comment 1 Aurélien Zanelli 2014-10-14 14:21:52 UTC 
Created attachment 288522 [details] [review]
vc1parse: select caps according to wmv format at negotiation

Patch proposal to fix the issue.

At negotiation, I intersect according to WMV format to select caps.
Comment 2 Aurélien Zanelli 2014-10-14 14:23:21 UTC 
Ooops there is a typo issue for my decoder caps in WMV3: it's header-format: sequence-layer, not header-format: sequence-layer-raw-frame
Comment 3 Sebastian Dröge (slomo) 2014-10-20 10:20:36 UTC 
commit 89455b710629e5c842512ad5d93cff6b771d0d72
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Wed Oct 1 16:17:46 2014 +0200

    vc1parse: select caps according to wmv format at negotiation
    
    Some VC1 decoder can have different caps according to wmv format, ie
    WMV3 or WVC1.
    So instead of keeping the first available caps, we interserct with
    current WMV format.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738532