Bug 738527 – Crash when trying to get the scale factor after the main window has been destroyed

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 738527 - Crash when trying to get the scale factor after the main window has been destroyed


Summary:	Crash when trying to get the scale factor after the main window has been dest...


Status:	RESOLVED FIXED

Product:	gnome-photos
Classification:	Applications
Component:	general
Version:	3.14.x
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME photos maintainer(s)
QA Contact:	GNOME photos maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-10-14 13:53 UTC by Debarshi Ray
Modified:	2015-02-23 15:40 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix crash when reading scale factor after window has been destroyed (1.53 KB, patch) 2014-11-10 14:14 UTC, Debarshi Ray	committed	Details \| Review
Fix crash when trying to use window after it has been destroyed (1.85 KB, patch) 2015-02-23 15:40 UTC, Debarshi Ray	committed	Details \| Review

Description Debarshi Ray 2014-10-14 13:53:41 UTC

I noticed this in my 'coredumpctl list' with 3.14.0:

Core was generated by `/usr/bin/gnome-photos --gapplication-service'.
Program terminated with signal SIGSEGV, Segmentation fault.

+ Trace 234223

#0 photos_application_get_scale_factor
at photos-application.c line 1100
#0 photos_application_get_scale_factor
at photos-application.c line 1100
#1 photos_utils_get_icon_size
at photos-utils.c line 487
#2 photos_base_item_populate_from_cursor
at photos-base-item.c line 692
#3 photos_base_item_populate_from_cursor
at photos-base-item.c line 731
#4 photos_base_item_populate_from_cursor
at photos-base-item.c line 832
#5 photos_base_item_constructed
at photos-base-item.c line 884
#6 photos_flickr_item_constructed
at photos-flickr-item.c line 335
#7 g_object_new_internal
at gobject.c line 1814
#8 g_object_new_valist
at gobject.c line 2034
#9 g_object_new
at gobject.c line 1617
#10 photos_item_manager_create_item
at photos-item-manager.c line 344
#11 photos_item_manager_add_item
at photos-item-manager.c line 296
#12 photos_item_manager_item_created_executed
at photos-item-manager.c line 61
#13 photos_single_item_job_cursor_next
at photos-single-item-job.c line 63
#14 photos_single_item_job_cursor_next
at photos-single-item-job.c line 90
#15 g_simple_async_result_complete
at gsimpleasyncresult.c line 763
#16 complete_in_idle_cb_for_thread
at gsimpleasyncresult.c line 832
#17 g_main_context_dispatch
at gmain.c line 3111
#18 g_main_context_dispatch
at gmain.c line 3710
#19 g_main_context_iterate
at gmain.c line 3781
#20 g_main_context_iteration
at gmain.c line 3842
#21 g_application_run
at gapplication.c line 2282
#22 main
at photos-main.c line 53
#1 photos_utils_get_icon_size
at photos-utils.c line 487

$3 = 0x26c9190 [PhotosApplication]
(gdb) print *app
$4 = {parent_instance = {g_type_instance = {g_class = 0x26c80f0}, ref_count = 2, qdata = 0x2711530}, 
  priv = 0x26c9100}
(gdb)

Comment 1 Debarshi Ray 2014-11-10 14:14:58 UTC

Created attachment 290347 [details] [review]
Fix crash when reading scale factor after window has been destroyed

Comment 2 Debarshi Ray 2015-02-23 15:40:01 UTC

Created attachment 297680 [details] [review]
Fix crash when trying to use window after it has been destroyed