GNOME Bugzilla – Bug 738517
Better empty snapshots UI
Last modified: 2016-03-31 13:22:07 UTC
<zeenix> jimmac: i'm sure you hate how the snapshot UI looks when there isn't any snapshots? :) <zeenix> jimmac: should we should a label instead there similar to what we show when there is no boxes? <zeenix> "No snapshots made yet. Create one using the button below." ? <zeenix> would be nice to show some icon too <jimmac> zeenix: can you file a bug on this? <zeenix> jimmac: sure
Created attachment 297596 [details] [review] snapshots-prop: Re-order UI setup code Re-order UI creation & setup code to make it easy to follow.
Created attachment 297597 [details] [review] snapshots-prop: Rename snapshot_stack to stack This private field didn't need to have such a long name given the context anyway but renaming mainly for adding another stack for which this name is better suited.
Created attachment 297598 [details] [review] snapshots-prop: Friendlier 'no snapshots' UI Instead of showing a blank frame when there are no snapshots, show a friendly message.
Created attachment 297599 [details] [review] props-page-widget: Let props fill vertically Lets not stop individual properties from filling the view vertically.
Created attachment 297600 [details] [review] snapshots-prop: Longer view Snapshots property has its own page and currently it takes only a part of the whole page, which doesn't look so good. This patch makes it take a lot of the (vertical) space given to it.
Created attachment 297601 [details] Screenshot before the patches
Created attachment 297602 [details] Screenshot after patches
Attachment 297596 [details] pushed as b40fd3b - snapshots-prop: Re-order UI setup code Attachment 297597 [details] pushed as 5eac769 - snapshots-prop: Rename snapshot_stack to stack Attachment 297598 [details] pushed as 3564601 - snapshots-prop: Friendlier 'no snapshots' UI Attachment 297599 [details] pushed as 0dca326 - props-page-widget: Let props fill vertically Attachment 297600 [details] pushed as b4180a2 - snapshots-prop: Longer view