After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738485 - Commit 36f051044c4653161ed844dff17df81a8d31fc13 breaks run against NetworkManager 0.9.8.8
Commit 36f051044c4653161ed844dff17df81a8d31fc13 breaks run against NetworkMan...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-13 20:55 UTC by bluescreen_avenger
Modified: 2014-10-31 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
networkAgent: Support NM versions without :capabilities (1.67 KB, patch)
2014-10-31 12:39 UTC, Florian Müllner
committed Details | Review

Description bluescreen_avenger 2014-10-13 20:55:36 UTC
I forget the exact error I get, but the changes in 36f051044c4653161ed844dff17df81a8d31fc13 causes GnomeShell to no longer run when using NetworkManager 0.9.8.8, which unfortunately is still used in the yet to be released Ubuntu 14.10
Comment 1 André Klapper 2014-10-14 05:26:48 UTC
Affecting 3.12 and 3.14. Introduced in bug 737592.
Comment 2 bluescreen_avenger 2014-10-31 12:15:43 UTC
Any update on this? I think I still need to run
git revert -n 36f051044c4653161ed844dff17df81a8d31fc13

to compile gnome-shell master on Ubuntu 14.10, as it is still using NetworkManager 0.9.8.8
(I haven't tried it without it since I reported)
Comment 3 Florian Müllner 2014-10-31 12:39:12 UTC
Created attachment 289727 [details] [review]
networkAgent: Support NM versions without :capabilities

Commit 36f051044c465316 bumped the requirement for NetworkManager,
which is problematic on a stable branch; optionally fall back to
the previous code.

Does this patch work for you?

I think there is a valid point in not bumping the NetworkManager requirement on the stable gnome-3-12 and gnome-3-14 branches (it's kinda rude), so degrading gracefully looks like the best option.
I don't see a strong reason to apply this to master though.
Comment 4 Florian Müllner 2014-10-31 12:40:21 UTC
Dan, does this make sense to you?
Comment 5 Dan Williams 2014-10-31 14:26:10 UTC
Yeah, sorry about that.  It wasn't my intent to require a newer version of NM; the patch looks correct.
Comment 6 Florian Müllner 2014-10-31 14:29:02 UTC
Attachment 289727 [details] pushed as ffa8ff7 - networkAgent: Support NM versions without :capabilities

Pushed to both gnome-3-12 and gnome-3-14 after IRC review.