After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738465 - Have a dconf switch to disable notifications
Have a dconf switch to disable notifications
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-13 14:59 UTC by Vadim Rutkovsky
Modified: 2014-10-14 09:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a dconf setting for enabling/disabling notifications BZ#738465 (2.20 KB, patch)
2014-10-14 02:15 UTC, David Gumberg 		none Details | Review

Description Vadim Rutkovsky 2014-10-13 14:59:14 UTC 
Downstream bug: https://bugs.launchpad.net/ubuntu/+source/gnome-music/+bug/1340848

Notifications might be annoying, so lets add an option to disable them
Comment 1 David Gumberg 2014-10-14 02:15:33 UTC 
Created attachment 288430 [details] [review]
Add a dconf setting for enabling/disabling notifications BZ#738465

Edited the gsettings schema to include a checkbox option for
enabling/disabling notifications, and added an 'if' in
application.py to check the value before enabling notifications.

The value name is 'notifications'.

This commit fixes BZ#738465.
Comment 2 Vadim Rutkovsky 2014-10-14 09:22:32 UTC 
Excellent job, I pushed the patch with a slight modification (spaces instead of tabs) as https://git.gnome.org/browse/gnome-music/commit/?id=0196208