After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738449 - vc1parse: just assume none header-format when no codec_data is present
vc1parse: just assume none header-format when no codec_data is present
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-13 12:12 UTC by Aurélien Zanelli
Modified: 2014-10-25 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vc1parse: just assume none header-format when no codec_data is present (1.19 KB, patch)
2014-10-13 12:14 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-10-13 12:12:47 UTC 
In method gst_vc1_parse_set_caps(), if we have no codec_data, we assume that header-format is none. Then we test header-format caps value and if differs from sequence-layer, we set sequence-layer as input_header_format.

I think this is currently wrong since we have no codec_data we should just assume that input header-format is none.
Comment 1 Aurélien Zanelli 2014-10-13 12:14:20 UTC 
Created attachment 288379 [details] [review]
vc1parse: just assume none header-format when no codec_data is present

Patch proposal
Comment 2 Sebastian Dröge (slomo) 2014-10-14 08:23:44 UTC 
commit 77453c812477de10326b9e6a9088b8bf918d150c
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Mon Oct 13 14:05:24 2014 +0200

    vc1parse: just assume none header-format when no codec_data is present
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738449