After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738401 - vim: Add support for half page up/down (ctrl+u/d)
vim: Add support for half page up/down (ctrl+u/d)
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-12 16:50 UTC by Hashem Nasarat
Modified: 2014-10-12 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vim: Consolidate gb_editor_vim_page_up and down functions (4.39 KB, patch)
2014-10-12 16:50 UTC, Hashem Nasarat 		committed Details | Review
vim: Remove unneeded MAX macro in move_page up (910 bytes, patch)
2014-10-12 16:50 UTC, Hashem Nasarat 		committed Details | Review
vim: Add support for half page up/down (ctrl+u/d) (3.04 KB, patch)
2014-10-12 16:50 UTC, Hashem Nasarat 		committed Details | Review

Description Hashem Nasarat 2014-10-12 16:50:21 UTC 
I also cleaned up the code so the implementation would be simpler.
I wasn't sure what to do with the old ctrl+u code, but as that behavior
doesn't match vim I just deleted it.

Can someone please review (& merge?) these?
Comment 1 Hashem Nasarat 2014-10-12 16:50:23 UTC 
Created attachment 288334 [details] [review]
vim: Consolidate gb_editor_vim_page_up and down functions

They use mostly shared code, so there's no reason for the repetition.
Comment 2 Hashem Nasarat 2014-10-12 16:50:27 UTC 
Created attachment 288335 [details] [review]
vim: Remove unneeded MAX macro in move_page up

It's never going to be less than 0.
Comment 3 Hashem Nasarat 2014-10-12 16:50:32 UTC 
Created attachment 288336 [details] [review]
vim: Add support for half page up/down (ctrl+u/d)
Comment 4 Christian Hergert 2014-10-12 17:29:13 UTC 
Attachment 288334 [details] pushed as bd6671d - vim: Consolidate gb_editor_vim_page_up and down functions
Attachment 288335 [details] pushed as 7c0fc4c - vim: Remove unneeded MAX macro in move_page up
Attachment 288336 [details] pushed as 718d090 - vim: Add support for half page up/down (ctrl+u/d)
Comment 5 Christian Hergert 2014-10-12 17:29:46 UTC 
Nice work! Pushed to master!