After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738374 - gfile: g_file_equal (x, x) is TRUE
gfile: g_file_equal (x, x) is TRUE
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-10-12 00:49 UTC by Benjamin Otte (Company)
Modified: 2014-10-21 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gfile: g_file_equal (x, x) is TRUE (880 bytes, patch)
2014-10-12 00:49 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Benjamin Otte (Company) 2014-10-12 00:49:31 UTC 
Here's a tiny optimization/clarification for g_file_equal().
Comment 1 Benjamin Otte (Company) 2014-10-12 00:49:33 UTC 
Created attachment 288295 [details] [review]
gfile: g_file_equal (x, x) is TRUE

So shortcut it.

I wrote this patch less as a performance optimization and more as a
clarification, so that people looking at the code can be assured of this
invariant.
Comment 2 Allison Karlitskaya (desrt) 2014-10-15 08:05:47 UTC 
Review of attachment 288295 [details] [review]:

Looks good.
Comment 3 Benjamin Otte (Company) 2014-10-21 20:52:03 UTC 
Attachment 288295 [details] pushed as 4125415 - gfile: g_file_equal (x, x) is TRUE