GNOME Bugzilla – Bug 738332
application/x-rtp caps field have different names in the send and receive paths...
Last modified: 2018-11-03 14:55:04 UTC
Before 1.0, Wim renamed the "clock-base" and "seqnum-base" fields in GstRtpBasePayload into "timestamp-offset" and "seqnum-offset". But he failed to rename them elsewhere. So that broke RTP dtmf sending in all 1.x releases. I've now fixed it in the master and 1.4 branches, that was bug #738297. But I only changed the elements that are in the "send" path, not those in the receive path. So right now we're in the ugly state where application/x-rtp caps are different for sending and receiving. Although this is technically an API break and is not strictly necessary, I think we should just bite the bullet and update the receive side caps to match the send-side ones in time for 1.x. The rtpsource stats also use the name seqnum-base, we may also want to break API there and update the name too.
Created attachment 288260 [details] [review] rtpmanager: Rename clock-base and seqnum-base to timestamp-offset and seqnum-offset These were renamed in GstRtpBasePayload in 1.0.
Created attachment 288261 [details] [review] rtpsource: Rename seqnum-base to seqnum-offset in the statistics This was renamed in the caps before 1.0, update to match.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/135.