After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738331 - mpegtsbase: Do a hard reset on DISCONT buffers in push mode.
mpegtsbase: Do a hard reset on DISCONT buffers in push mode.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.6.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-10 21:26 UTC by Mathieu Duponchelle
Modified: 2016-08-31 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implements the proposed enhancement (1.04 KB, patch)
2014-10-10 21:26 UTC, Mathieu Duponchelle 		none Details | Review

Description Mathieu Duponchelle 2014-10-10 21:26:49 UTC 
Created attachment 288259 [details] [review]
implements the proposed enhancement

When in push mode, observations about timestamps and segments should be reset when receiving a DISCONT buffer.

There are specific comments in both _packetizer_flush and _ts_demux_flush that these informations should be kept around in pull mode seeks, but keeping them after getting a DISCONT buffer leads to faulty behaviour.
Comment 1 Tim-Philipp Müller 2014-10-10 22:07:32 UTC 
> There are specific comments in both _packetizer_flush and _ts_demux_flush that
> these informations should be kept around in pull mode seeks, but keeping them
> after getting a DISCONT buffer leads to faulty behaviour.

Could you elaborate on this?
Comment 2 Mathieu Duponchelle 2016-08-31 23:26:54 UTC 
Sorry :(

This was done in 631b2d88262e28d6c96ec8a266536760b9e24bef by Edward, (one year later, sorry again)

Closing as RESOLVED, even though I don't really know how to reproduce the code now seems to do the right thing, past me should really have attached a validate pipeline or something.