GNOME Bugzilla – Bug 738153
Plugin Writer's Guide: typo in 'Dynamic negotiation' section
Last modified: 2014-10-10 09:38:47 UTC
See the example at the bottom of http://gstreamer.freedesktop.org/data/doc/gstreamer/head/pwg/html/section-nego-usecases.html Either I misunderstood something or "gst_pad_set_caps (filter->sinkpad, caps)" should be called on the srcpad.
Created attachment 288041 [details] [review] advanced-negotiation: fix typo in 'Dynamic negotiation' section The point of this example is to show how to set caps on the source pad once it has been set on the sink pad. So, in passthrough mode, the caps is just copied to the source pad.
Created attachment 288043 [details] [review] advanced-allocation: fix typo
(In reply to comment #2) > Created an attachment (id=288043) [details] [review] > advanced-allocation: fix typo Not related to this bug but I don't bother creating a new one.
Created attachment 288108 [details] [review] advanced-qos: fix typo
Not sure that code is really correct like that in any case, but I do think you're right about the typo. commit cea054c84aa4ecf13dd96f3d50d2b203f865496c Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Wed Oct 8 16:03:20 2014 +0200 docs: pwg: fix two typos https://bugzilla.gnome.org/show_bug.cgi?id=738153 commit 2cc55af04626e3ba10070a12933e755c68242ce6 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Wed Oct 8 15:37:37 2014 +0200 docs: pwg: fix typo in 'Dynamic negotiation' section The point of this example is to show how to set caps on the source pad once it has been set on the sink pad. So, in passthrough mode, the caps is just copied to the source pad. https://bugzilla.gnome.org/show_bug.cgi?id=738153