After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738153 - Plugin Writer's Guide: typo in 'Dynamic negotiation' section
Plugin Writer's Guide: typo in 'Dynamic negotiation' section
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-08 13:37 UTC by Guillaume Desmottes
Modified: 2014-10-10 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
advanced-negotiation: fix typo in 'Dynamic negotiation' section (1.04 KB, patch)
2014-10-08 13:39 UTC, Guillaume Desmottes
committed Details | Review
advanced-allocation: fix typo (975 bytes, patch)
2014-10-08 14:03 UTC, Guillaume Desmottes
committed Details | Review
advanced-qos: fix typo (957 bytes, patch)
2014-10-09 10:35 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2014-10-08 13:37:27 UTC
See the example at the bottom of http://gstreamer.freedesktop.org/data/doc/gstreamer/head/pwg/html/section-nego-usecases.html

Either I misunderstood something or "gst_pad_set_caps (filter->sinkpad, caps)" should be called on the srcpad.
Comment 1 Guillaume Desmottes 2014-10-08 13:39:40 UTC
Created attachment 288041 [details] [review]
advanced-negotiation: fix typo in 'Dynamic negotiation' section

The point of this example is to show how to set caps on the source pad once
it has been set on the sink pad.
So, in passthrough mode, the caps is just copied to the source pad.
Comment 2 Guillaume Desmottes 2014-10-08 14:03:41 UTC
Created attachment 288043 [details] [review]
advanced-allocation: fix typo
Comment 3 Guillaume Desmottes 2014-10-08 14:04:22 UTC
(In reply to comment #2)
> Created an attachment (id=288043) [details] [review]
> advanced-allocation: fix typo

Not related to this bug but I don't bother creating a new one.
Comment 4 Guillaume Desmottes 2014-10-09 10:35:56 UTC
Created attachment 288108 [details] [review]
advanced-qos: fix typo
Comment 5 Tim-Philipp Müller 2014-10-10 09:38:09 UTC
Not sure that code is really correct like that in any case, but I do think you're right about the typo.

commit cea054c84aa4ecf13dd96f3d50d2b203f865496c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Oct 8 16:03:20 2014 +0200

    docs: pwg: fix two typos
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738153

commit 2cc55af04626e3ba10070a12933e755c68242ce6
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Oct 8 15:37:37 2014 +0200

    docs: pwg: fix typo in 'Dynamic negotiation' section
    
    The point of this example is to show how to set caps
    on the source pad once it has been set on the sink pad.
    So, in passthrough mode, the caps is just copied to the
    source pad.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738153