After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738142 - make distcheck should be executable without prior execution of make
make distcheck should be executable without prior execution of make
Status: RESOLVED FIXED
Product: yelp-tools
Classification: Core
Component: yelp.m4
git master
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-08 10:10 UTC by Sebastian
Modified: 2014-10-10 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes the make distcheck error (1.19 KB, patch)
2014-10-08 13:35 UTC, Sebastian
committed Details | Review

Description Sebastian 2014-10-08 10:10:22 UTC
I believe it is a bug if it is not possible to run 'make distcheck' without first running 'make'. At least in the automake based projects which I usually work with this is possible. Also the folks at #autotools on IRC seem to aggree with that:

    <lanoxx> is it required to run 'make' before 'make distcheck' or is 
             it a bug it make distcheck fails if 'make' has not been run before?
    <pehjota> lanoxx: Sounds like a bug in the package, like it's trying
              to distribute files that are generated at build time. [...]

I was told on #gtk that it is the case for all project which use yelp (or gtk-doc), that they have to run 'make' first followed my 'make distcheck'.

I would like to ask that either:

 * yelp-tools is fixed. Probably this requires some change in yelp.m4?
 * Or if it requires a change in each of the project, that this is probably documented somewhere. Possibly here [1].

Please don't argue that is easily possible to just run 'make' first. When one forgets this or does not know about it, then its not very obvious what when wrong and 'make distcheck' will just output an error that looks like this:

make[3]: Entering directory `/home/sebastiangeiger/Documents/Code/gnome-applets/drivemount/help'
cp: cannot stat ‘./ca/index.docbook’: No such file or directory

This leaves it to the developer/user to guess that he forgot to run 'make'. But my first guess what that I forgot to add some important configure options or that some required tools where missing.

Thank you for your time.

 [1] https://wiki.gnome.org/Apps/Yelp/Tools/yelp.m4
Comment 1 Sebastian 2014-10-08 13:35:34 UTC
Created attachment 288040 [details] [review]
Fixes the make distcheck error

The attached patch fixes the described 'make distcheck' error, by adding the $(_HELP_LC_FILES) as dependency to distdir-help-files.
Comment 2 Sebastian 2014-10-08 13:36:49 UTC
I also asked in #autotools again to clarify things:

    <lanoxx> va, in don't know if you know yelp-tools, but it seems that
             it does not generate those files and instead require the user
             to run make first and the make distcheck
    <va> lanoxx: well that's a bug.  configure && make distcheck  is
         supposed to generate a functional package
Comment 3 Shaun McCance 2014-10-10 13:53:45 UTC
Comment on attachment 288040 [details] [review]
Fixes the make distcheck error

Looks good. Thanks.
Comment 4 Sebastian 2014-10-10 13:58:10 UTC
Fixed by commit d18d4ff5cb67a07977aa9957fe82322b22380ef3.
Comment 5 Sebastian 2014-10-10 13:58:47 UTC
Review of attachment 288040 [details] [review]:

Commited.