After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738092 - basesink: clamp reported position based on direction
basesink: clamp reported position based on direction
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-07 14:46 UTC by Edward Hervey
Modified: 2014-12-11 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basesink: clamp reported position based on direction (1.29 KB, patch)
2014-10-07 14:46 UTC, Edward Hervey
none Details | Review

Description Edward Hervey 2014-10-07 14:46:12 UTC
When using a negative rate (rate being segment.rate * segment.applied_rate),
we will end up reporting decreasing positions, therefore adjust the clamping
against last reported value accordingly.

Fixes positions getting properly reported with applied_rate < 0.0
Comment 1 Edward Hervey 2014-10-07 14:46:15 UTC
Created attachment 287967 [details] [review]
basesink: clamp reported position based on direction
Comment 2 Edward Hervey 2014-12-01 09:48:35 UTC
commit 05092eda8ebd241747b70c3a73aca520cfacccab
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue Oct 7 16:44:45 2014 +0200

    basesink: clamp reported position based on direction
    
    When using a negative rate (rate being segment.rate * segment.applied_rate),
    we will end up reporting decreasing positions, therefore adjust the clamping
    against last reported value accordingly.
    
    Fixes positions getting properly reported with applied_rate < 0.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738092