After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738077 - Setting non-default language is unnecessarily difficult
Setting non-default language is unnecessarily difficult
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-07 12:11 UTC by Ondrej Holy
Modified: 2014-10-31 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user-accounts: simplify language changing thru users panel (11.02 KB, patch)
2014-10-15 12:39 UTC, Ondrej Holy
committed Details | Review
cc-language-chooser: do not show all languages after _clear_filter (2.52 KB, patch)
2014-10-15 12:41 UTC, Ondrej Holy
needs-work Details | Review
cc-language-chooser: Reset dialog to original state when used the 2nd time (2.81 KB, patch)
2014-10-15 14:11 UTC, Ondrej Holy
committed Details | Review

Description Ondrej Holy 2014-10-07 12:11:15 UTC
There is unnecessarily too much steps to set non-default language thru users panel:
1/ click on editable combo, it shows combo with default languages
2/ click on "Other...", it shows language chooser with the same default languages (just sorted differently)
3/ click on "..." to show all languages

One of the steps could be omitted, so it could be fixed in two ways:
- do not show the combo and show the language chooser immediately (same as it is done in region panel)
- or show directly all languages in the chooser after clicking to "Other..." in the combo

Designers, what is better?
Comment 1 Jakub Steiner 2014-10-15 09:03:01 UTC
Looks like we are duplicating the "common case" twice, indeed. I'd drop the menu myself and go directly to the modal dialog. I think it's going to be cleaner in terms of code as well?
Comment 2 Ondrej Holy 2014-10-15 09:07:23 UTC
Yes, this option is definitely cleaner from my perspective. :-)
Comment 3 Bastien Nocera 2014-10-15 12:16:17 UTC
Turning the drop-down menu into a button is probably the easiest indeed.
Comment 4 Ondrej Holy 2014-10-15 12:39:43 UTC
Created attachment 288576 [details] [review]
user-accounts: simplify language changing thru users panel

Do not show combo box with common languages and show the language chooser immediately as it is done in the region panel.
Comment 5 Ondrej Holy 2014-10-15 12:41:45 UTC
Created attachment 288577 [details] [review]
cc-language-chooser: do not show all languages after _clear_filter

There is another bug fix, because this bug is more visible now thanks to the previous patch.

Function cc_language_chooser_clear_filter clears just filter label, however the label is shown and all languages are listed. Clear the dialog to the initial state on cc_language_chooser_clear_filter so that we can reuse the dialog later.
Comment 6 Bastien Nocera 2014-10-15 12:56:54 UTC
Review of attachment 288576 [details] [review]:

Looks good.
Comment 7 Bastien Nocera 2014-10-15 12:57:12 UTC
Review of attachment 288576 [details] [review]:

Make that after freeze, we haven't branched yet.
Comment 8 Bastien Nocera 2014-10-15 12:58:30 UTC
Review of attachment 288577 [details] [review]:

What's that patch for? The commit message doesn't explain the user-visible results of this.
Comment 9 Ondrej Holy 2014-10-15 13:16:31 UTC
The language chooser dialog is used repeatedly. When we click to show more languages and/or select language, close the dialog and show it again e.g. for different user, the chooser isn't in an initial state. So filter entry isn't hidden (and all languages are shown) and/or it is focused the last focused language. But I think the dialog should be in the initial state when it is open... is this clearer?
Comment 10 Bastien Nocera 2014-10-15 13:20:38 UTC
(In reply to comment #9)
> The language chooser dialog is used repeatedly. When we click to show more
> languages and/or select language, close the dialog and show it again e.g. for
> different user, the chooser isn't in an initial state. So filter entry isn't
> hidden (and all languages are shown) and/or it is focused the last focused
> language. But I think the dialog should be in the initial state when it is
> open... is this clearer?

It's clearer, can you please incorporate this into the commit message, and make sure that the subject line contains the description of the user-visible changes, not a shorter version of what's in the body.
Comment 11 Ondrej Holy 2014-10-15 14:11:27 UTC
Created attachment 288591 [details] [review]
cc-language-chooser: Reset dialog to original state when used the 2nd time

With updated description...
Comment 12 Bastien Nocera 2014-10-15 14:15:17 UTC
Review of attachment 288591 [details] [review]:

Looks good.
Comment 13 Ondrej Holy 2014-10-15 14:30:03 UTC
Comment on attachment 288591 [details] [review]
cc-language-chooser: Reset dialog to original state when used the 2nd time

commit 066d66383e9c3d476eb85c6f6e8dfd42e6eb2bac

Thanks for the reviews.
Comment 14 Ondrej Holy 2014-10-31 08:24:18 UTC
Comment on attachment 288576 [details] [review]
user-accounts: simplify language changing thru users panel

commit 96c0c0a838dd14fa27962968649395949b0664b5