GNOME Bugzilla – Bug 738057
In Files application property dialog Orca doesn't read some property related labels containing texts
Last modified: 2018-02-08 13:05:33 UTC
Created attachment 287917 [details] Debug file with shows possible why happening this issue Dear Joanie, When I using GNOME Files application and presents a folder or a file related properties dialog, Orca doesn't read some importanter labels values when the caret land this labels (for example the size, place, type, etc). With my braille display correct presents Orca both the label and containing text. Easy reproducable testcase: 1. Goto your home folder. 2. Select a file or a folder, and present properties dialog (press for example the ALT+ENTER keystroke). This situation the properties dialog presents the screen, and you land first the name text. 3. Press a TAB key. This situation you see the screen with the type related information. Expected result this step: Orca need speaks the type related label, the filled text, selection state and rolename related informations. Actual result: I hear only the type related label, the selected state message and the label rolename. Where am I output feature affected too. My environment related informations: OS: Ubuntu 14.04 Orca version: latest master branch Affected Orca branches: master, gnome-3-14 Files application version: 3.10 series. I attaching a debug.out file. Attila
Created attachment 287918 [details] [review] Fix patch for this bug I attaching a patch with me correct resolve this issue. When I now repeat the wrote testcase, Orca correct announce all importanter informations in GNOME Files application file properties dialog (the file size, file type, file place, access time). Where am I output command announce too right this informations. I do a minimal change in src/orca/formatting.py source file (I using labelAndName directive with focused, unfocused and basic where am I parts with pyatspi.role_label rolename related). If this fix is safe your openion the default formatting related source file, please commit this fix both master and gnome-3-14 branch. Without this change Orca me not announce this importanter informations a file or a folder related, only possible reading the values with flatreview feature (except if the user not using a braille display). Attila
Created attachment 287919 [details] The good working method related debug.out file This debug.out shows final how need working the bug fix if need doing other fix method. I repeated the wrote testcase after I applyed my previous comment attached patch. Clear see the debug.out file Orca announce all importanter informations, and where am I output command doing this task perfect too. Attila
This issue related not only the Files application affected, for example the gnome-control-center details preference pane producing similar simptomns. Testcase: 1. Launch gnome-control-center preference tool. 2. In personal page click Details button. 3. The default focused owerview pane jump between labels with TAB and SHIFT+TAB keys. Expected result: Orca need speak and present braille with the widget label and the content (what type your processor, what your video card type, etc). Actual result: Braille Orca producing the expected result, but in speech Orca speaks only the widget label (memory selected label, processor selected label, etc). If I applying my attached patch, gnome-control-center details pane is full accessible, both speech and braille Orca producing expected result. Attila
Hi Joanie, If you have a little time, can you review my patch this bug related? If my patch is good, need committing this patch both Orca master branch and gnome-3-14 branch to this fix lands the Orca 3.14.3 future maintenance release. Attila
Committed to both master and the 3.14 branch. Thanks!
It worked fine in my environment. I have a small observation. When I set verbosity level to brief, orca reads the word label after read the content of the label. For example: "file type folder selected label". This is not a problem, but in my opinion the word label could be suppressed if the verbosity level is set to brief. Great job.
Hi José, I think I understanding you what would like, but please confirm: If you using brief verbosity setting, you would like hide the rolename and selection state related informations? This situation I think you requested output is following if the speech verbosity setting is brief and you request property dialog a folder related: Type: file type folder Orca this situation not examining now the verbosity setting, but this is an easy thing I think in formatting.py before set the pyatspi.role_Label rolename related formatting values. Joanie, your openion have risk if I try handling josé request this situation with other applications speech output related? This change affecting only the pyatspi.role_Label formatting values. Now, Orca use following formatting values with pyatspi.role_Label related, independent if the verbosity setting is verbose or brief: 'focused': 'labelAndName + allTextSelection + roleName', 'unfocused': 'labelAndName + allTextSelection + roleName', 'basicWhereAmI': 'labelAndName + allTextSelection + roleName' If the verbosity setting is brief, we need sending I think only the 'labelAndName formatting value. Now my machine building a live system, but I will looking this change and reporting the result experiences with brief verbosity setting this day. Attila
(In reply to Hammer Attila from comment #7) > Hi José, > > I think I understanding you what would like, but please confirm: > If you using brief verbosity setting, you would like hide the rolename and > selection state related informations? Hi Attila. In my opinion only rolename should be omitted. Selection state is important and should be announced. If I know that an information is selected, I can copy it to clipboard. As I said before this is not a problem.
Hi José, This is possible with you would like. If I remove the rolename part in the quoted code part, Orca not announce rolename information in Files property dialog, except the name related widget, with containing the filename. This widget at-spi or ATK identifying with an edit box, this situation Orca using different formatting value setting. If you type different text in Files property dialog the name text box and click the close button, you rename the selected item. This is true only if you previous selected one file or one folder and request the selected folder properties. This bug affected previous only the label rolename with src/orca/formatting.py related, so if I remove the rolename part if the verbosity setting is brief with affected code part, you only hear difference the pyatspi.role_Label widget speech output when you using brief verbosity setting. If all or more rolenames related you would like this change, need determining I think in Orca list how many users not would like hear rolenames if the verbosity setting is brief, and what rolenames need changing this working method with brief verbosity setting related. For example with web elements I think both two speech verbosity settings need hear the rolenames, a text box related need known you land a text box, etc. With braille verbosity setting I think when the verbosity setting is brief, Orca not send braille display the rolename related informations, except if the rolename not have a braille indicator, but I am not full sure this. Oldest time Orca have defined exceptions this working method related, but I don't no now what the case. Joanie, what your openion? I do this change only with pyatspi.role_Label rolename related if the speech verbosity setting is brief, or we keep the now used method both two speech verbosity settings? Attila
Before you do it based on verbosity, I think it might be worth considering if there are some type of labels where the role should be spoken and other types of labels where the role should not be spoken. For instance, if you are in a Gtk+ message box and tab to a label in which it is possible to use caret navigation to move within and optionally select a portion of the text, should the role be spoken? Since apparently this bug is not yet fixed, I'll reopen it. :)
Hi Joanie, I tested a message dialog now with Zenity, I used zenity --info command. When Orca reading dialog content, Orca not announced the rolename and selection state first time when the OK button get focus, this is right. When I press a TAB key, the focus jumps the message label, this situation Orca announce label content, selection state and rolename. Default this situation entire message label content is selected, and possible copying to clipboard the label content. Testcase: Simple try zenity --info, zenity --error commands, press a TAB key and press CTRL+C keystroke. In clipboard you have entire message label content. If in message label I using selection operations, during selection Orca not spokening right with rolename related informations. So, if I press HOME key in the label and try selecting two words from the message label, the selection announcement works right and possible copying only two words to the clipboard. Now, because not defined detailed where am I formatting value with pyatspi.role_Label rolename related (similar with oldest Orca releases), Orca repeating entire message label content when the message label is focused and the user doing a where am I operation. This is the default working method with where am I operation with labels related the oldest Orca releases too. Testcase: 1. Launch zenity --info, zenity --error commands. 2. Press TAB key. 3. Press home, and select one or two words. 4. Use where am I operation. You hear entire message label content, selected state and rolename, similar with oldest Orca releases. If not selected entire the message label content, where am I operation says only the label content and rolename. What the next step? what need changing? Attila