After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738018 - typefind: #define gst_type_find_peek is not needed any more
typefind: #define gst_type_find_peek is not needed any more
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-06 17:53 UTC by Danny Song (sedman)
Modified: 2014-10-07 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
#define gst_type_find_peek is not needed any more (175.90 KB, patch)
2014-10-06 17:53 UTC, Danny Song (sedman) 		none Details | Review
#define gst_type_find_peek is not needed any more (175.90 KB, patch)
2014-10-06 18:08 UTC, Danny Song (sedman) 		none Details | Review
attached in git format-patch (1.04 KB, patch)
2014-10-06 21:01 UTC, Danny Song (sedman) 		committed Details | Review

Description Danny Song (sedman) 2014-10-06 17:53:53 UTC 
Created attachment 287872 [details] [review]
#define gst_type_find_peek is not needed any more

#define gst_type_find_peek is not needed anymore.

Because,
It was added when merging between 0.1xx.
  see  "git log 09e06add6600f1b627322da8c13669279abecd25"
And current gst_type_find_peek returns const guint8 *.

So I think it's better to remove.

Correct me if I'm wrong and please review.
Comment 1 Danny Song (sedman) 2014-10-06 18:08:43 UTC 
Created attachment 287874 [details] [review]
#define gst_type_find_peek is not needed any more
Comment 2 Danny Song (sedman) 2014-10-06 21:01:20 UTC 
Created attachment 287882 [details] [review]
attached in git format-patch
Comment 3 Sebastian Dröge (slomo) 2014-10-07 11:54:52 UTC 
commit bb6ea450e8d0267498be8a56f9125533aa0831d1
Author: Danny Song <danny.song.ga@gmail.com>
Date:   Tue Oct 7 05:50:56 2014 +0900

    typefindfunctions: Remove leftover #define from 0.10
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738018