After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738010 - tui: fix some valgrind warnings
tui: fix some valgrind warnings
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmtui
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-06 14:51 UTC by Dan Winship
Modified: 2014-10-07 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tui: fix some valgrind warnings (1.42 KB, patch)
2014-10-06 14:51 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2014-10-06 14:51:03 UTC
nmt_newt_grid_size_allocate() depends on nmt_newt_grid_size_request()
having been called immediately prior, which would normally be true,
except that NmtNewtSection adjusts the label widgets in its border to
match its allocation, so when its size changes, it will end up calling
size_allocate() on the border with out-of-date requisition data. Fix
that by re-size_requesting the border after modifying it.
Comment 1 Dan Winship 2014-10-06 14:51:05 UTC
Created attachment 287856 [details] [review]
tui: fix some valgrind warnings
Comment 2 Dan Williams 2014-10-06 20:51:21 UTC
Looks good to me.  allocate() clearly depends on stuff that size_request() sets.
Comment 3 Dan Winship 2014-10-07 11:54:51 UTC
Attachment 287856 [details] pushed as 4f9f33f - tui: fix some valgrind warnings