GNOME Bugzilla – Bug 738002
fix language chooser response
Last modified: 2014-10-07 10:16:29 UTC
Created attachment 287847 [details] [review] fix language chooser response If the language chooser is confirmed and no language is selected, "Other..." is shown as user's language and the following error is printed: (gnome-control-center:14608): AccountsService-CRITICAL **: act_user_set_language: assertion 'language != NULL' failed
Review of attachment 287847 [details] [review]: Looks fine. Can you do the same for the region panel too ?
(In reply to comment #1) > Can you do the same for the region panel too ? I wasn't clear. Feel free to push the same fix to the region panel without review :-)
It seems to me region panel doesn't have such problems, because the language chooser is always preset by a current (or system, or default) language.
Created attachment 287934 [details] [review] preset language chooser if language is known Preset the language chooser similary as it is done in the region panel. Also remove one goto command and share code.
Created attachment 287935 [details] [review] fix language chooser response if language is unknown There is another one crasher. If language is unknown and language chooser is cancelled, panel crash with the following error: (gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_path: assertion 'iter->stamp == priv->stamp' failed (gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_value: assertion 'iter_is_valid (iter, list_store)' failed (gnome-control-center:24952): GLib-GObject-WARNING **: gtype.c:4221: type id '0' is invalid (gnome-control-center:24952): GLib-GObject-WARNING **: can't peek value table for type '<invalid>' which is not currently referenced Segmentation fault (core dumped)
Review of attachment 287934 [details] [review]: Right, this looks better
Review of attachment 287935 [details] [review]: ++
Comment on attachment 287847 [details] [review] fix language chooser response commit 6f13d0ad8b71b0c49593b87bfa7b7066e9aa32f6
Comment on attachment 287934 [details] [review] preset language chooser if language is known commit 6b3b223668a8a86d3264a86d78f2c790a9e5f648
Comment on attachment 287935 [details] [review] fix language chooser response if language is unknown commit 4c6ef8568db72455838625c1aed31b50772ab875
Thanks for the reviews :-)