After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737936 - Freebase: Add GType for GDataFreebaseSearchResultItem
Freebase: Add GType for GDataFreebaseSearchResultItem
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-05 17:47 UTC by Carlos Garnacho
Modified: 2014-12-23 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
freebase: Add GType for GDataFreebaseSearchResultItem (3.77 KB, patch)
2014-10-05 17:48 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2014-10-05 17:47:31 UTC 
Even though the usage pattern of GDataFreebaseSearchResultItem (with its lifetime attached to the GDataFreebaseSearchResult object) doesn't require much knowledge about it's memory management details, bindings have a hard time knowing how to deal with a const/opaque struct pointer (most notably gjs). 

I suggest to just wrap it in a boxed type to make bindings happy, we don't even need to expose copy/free in the C API, plus it's not so useful there.
Comment 1 Carlos Garnacho 2014-10-05 17:48:00 UTC 
Created attachment 287772 [details] [review]
freebase: Add GType for GDataFreebaseSearchResultItem

Making it a boxed type makes it friendly to bindings, as there's
some more embedded knowledge about how to deal with this type
memory-wise.
Comment 2 Philip Withnall 2014-10-16 08:32:42 UTC 
Review of attachment 287772 [details] [review]:

Looks good. Does gdata-sections.txt in gtk-doc boilerplate need updating to ignore the new *_get_type() function?
Comment 3 Carlos Garnacho 2014-12-23 10:19:29 UTC 
Attachment 287772 [details] pushed as 2a939fd - freebase: Add GType for GDataFreebaseSearchResultItem