After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737928 - dcaparse: should be more strict about frame header parsing
dcaparse: should be more strict about frame header parsing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-05 13:56 UTC by Matej Knopp
Modified: 2018-05-14 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (835 bytes, patch)
2014-10-05 13:56 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2014-10-05 13:56:20 UTC 
Created attachment 287760 [details] [review]
Patch

If frame header contains invalid channel configuration gst_dca_parse_parse_header accepts such frame and returns 0 channel count. That's outside of caps range (channels = (int) [ 1, 8 ]) and it doesn't really make sense for downstream. 

I think such frame should probably be ignored.

Also, it would be nice to have header crc check :) Although  it wouldn't help  with this particular file as there is no crc present.
Comment 1 Edward Hervey 2018-05-06 09:11:32 UTC 
Thanks !