After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737913 - DBus timeout attribute does not work for client methods
DBus timeout attribute does not work for client methods
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
0.24.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-05 01:59 UTC by David Lechner
Modified: 2016-09-17 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test case (926 bytes, text/x-vala)
2014-10-05 01:59 UTC, David Lechner 		  Details
patch applicable to master (0.33.1) (3.95 KB, patch)
2016-09-16 20:17 UTC, Michele Dionisio 		committed Details | Review

Description David Lechner 2014-10-05 01:59:02 UTC 
Created attachment 287742 [details]
Test case

According to <https://wiki.gnome.org/Projects/Vala/Manual/Attributes>, the DBus timeout attribute should work for client methods. It does not seem like this is actually implemented though.

In the attached test.vala, in the generated c code, you can see that in spite of the attribute it uses "g_dbus_proxy_get_default_timeout ((GDBusProxy *) self)" for the timeout argument of "g_dbus_connection_send_message_with_reply".

A quick glance at valagdbusclientmodule.vala looks like it is just not implemented.
Comment 1 Michele Dionisio 2016-09-16 20:17:32 UTC 
Created attachment 335734 [details] [review]
patch applicable to master (0.33.1)
Comment 2 Rico Tzschichholz 2016-09-17 08:10:44 UTC 
commit 0431459492f94a9840f29abb143f7e29834e2d54
Author: Michele Dionisio <michele.dionisio@gmail.com>
Date:   Sat Sep 17 10:02:15 2016 +0200

    D-Bus: Support DBus.timeout attribute for client methods