After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737908 - [PATCH] Reread ai.vala.
[PATCH] Reread ai.vala.
Status: RESOLVED FIXED
Product: four-in-a-row
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: four-in-a-row-maint
four-in-a-row-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-04 23:19 UTC by Arnaud B.
Modified: 2014-10-05 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reread ai.vala. (19.03 KB, patch)
2014-10-04 23:19 UTC, Arnaud B. 		none Details | Review
Reread ai.vala. (19.07 KB, patch)
2014-10-04 23:52 UTC, Arnaud B. 		committed Details | Review
AI: remove tabs (25.26 KB, patch)
2014-10-05 00:31 UTC, Michael Catanzaro 		none Details | Review
Rework victory(). (8.63 KB, patch)
2014-10-05 02:15 UTC, Arnaud B. 		committed Details | Review
Remove tabs. (23.54 KB, patch)
2014-10-05 02:48 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2014-10-04 23:19:26 UTC 
Created attachment 287731 [details] [review]
Reread ai.vala.

Just rereading.
Comment 1 Arnaud B. 2014-10-04 23:52:18 UTC 
Created attachment 287736 [details] [review]
Reread ai.vala.
Comment 2 Michael Catanzaro 2014-10-05 00:29:13 UTC 
I just rewrote the commit message since I'm not sure what you meant by "reread" (the definition of that is "to read again" :).
Comment 3 Michael Catanzaro 2014-10-05 00:31:15 UTC 
Created attachment 287737 [details] [review]
AI: remove tabs

Not pushing since this would be a stupid reason to cause a merge conflict, in case you're working on this file right now or start to do so before you notice this.
Comment 4 Arnaud B. 2014-10-05 02:15:54 UTC 
Created attachment 287743 [details] [review]
Rework victory().

(In reply to comment #2)
> I just rewrote the commit message since I'm not sure what you meant by "reread"
> (the definition of that is "to read again" :).

Frenchism. “Reading one time just for fixing the style”.
Comment 5 Arnaud B. 2014-10-05 02:48:49 UTC 
Created attachment 287745 [details] [review]
Remove tabs.

Just replacing each tab with four spaces.
Comment 6 Michael Catanzaro 2014-10-05 15:48:49 UTC 
Attachment 287743 [details] pushed as 9207cab - Rework victory().
Attachment 287745 [details] pushed as d11ac4a - Remove tabs.