GNOME Bugzilla – Bug 737857
make check fails
Last modified: 2015-06-09 12:25:19 UTC
TEST: test-geouri... (pid=8746) /geouri/parse_uri: OK /geouri/valid_uri: OK /geouri/convert_uri: OK PASS: test-geouri TEST: test-gcglib... (pid=8766) /geocode/resolve_json: OK /geocode/search_json: OK /geocode/reverse: Got geocode answer: The Astolat @ 51,237036, -0,589483 OK /geocode/pub: ** ERROR:test-gcglib.c:221:test_pub: assertion failed (geocode_location_get_latitude (loc) == 51.2371416): (51,2368852 == 51,2371416) FAIL GTester: last random seed: R02S78fff29aeb01a9c5c63a72ea6650b0fa /bin/sh: line 1: 8745 Terminert gtester --verbose test-geouri test-gcglib Makefile:882: recipe for target 'test' failed make[3]: *** [test] Error 143 make[3]: Leaving directory '/home/kmaraas/src/gnome/geocode-glib/geocode-glib' Makefile:744: recipe for target 'check-am' failed make[2]: *** [check-am] Error 2 make[2]: Leaving directory '/home/kmaraas/src/gnome/geocode-glib/geocode-glib' Makefile:746: recipe for target 'check' failed make[1]: *** [check] Error 2 make[1]: Leaving directory '/home/kmaraas/src/gnome/geocode-glib/geocode-glib' Makefile:517: recipe for target 'check-recursive' failed make: *** [check-recursive] Error 1 *** Error during phase check of geocode-glib: ########## Error running make check *** [29/247]
Still seeing this in git master.
I get: ERROR:test-gcglib.c:240:test_pub: assertion failed (geocode_location_get_longitude (loc) == -0.5912356): (-0.5912357 == -0.5912356) Does this happen to you with a specific locale? eg. do you see your problem or mine with LC_ALL=en_GB.UTF-8 ?
Created attachment 303478 [details] [review] test-gcglib: Fix test for "Grand Canyon" from Europe First hit for "Grand Canyon" is "Grand Canyon, Ukraine": http://www.openstreetmap.org/relation/1493795 instead of the North American one.
Created attachment 303479 [details] [review] test-gcglib: Fix "Santa Maria Del Rio" searches The results are more precise now.
Created attachment 303480 [details] [review] test-gcglib: Fix pub searches There are multiple "Old Palace Road" objects in the database now.
Does this fix it? Just like the old Yahoo service, the results can be different depending on the location of the query (the IP really) and the language.
Yeah, the tests are a bit shaky. I often have to fix something up to be able to make a release. Having the tests depend on what is in the OSM database at this time is not really an optimal solution. Maybe it would be possible to use the API test server as a target? The check tests passed for me, both in the 3.17.1 and the 3.16.2 releases. I must invoke the tests with LANG=en.US to make it work though. Thanks for fixing things up Bastien!
Review of attachment 303478 [details] [review]: Looks good. ::: geocode-glib/test-gcglib.c @@ +376,2 @@ place = res->data; + g_test_message ("Location: %s", types[i].search_string); Is this meant to be here? Or a left-over debug message?
Review of attachment 303479 [details] [review]: Looks good!
Review of attachment 303480 [details] [review]: Looks good.
Attachment 303478 [details] pushed as 39b3cfc - test-gcglib: Fix test for "Grand Canyon" from Europe Attachment 303479 [details] pushed as 118ac86 - test-gcglib: Fix "Santa Maria Del Rio" searches Attachment 303480 [details] pushed as 22f47c3 - test-gcglib: Fix pub searches