After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737844 - sync pull API should not iterate main context
sync pull API should not iterate main context
Status: RESOLVED WONTFIX
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks: 739240
 
 
Reported: 2014-10-03 12:50 UTC by Colin Walters
Modified: 2018-08-17 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libostree: Add ostree_repo_pull_with_options() (8.82 KB, patch)
2014-10-26 20:58 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2014-10-03 12:50:07 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=1148975
Comment 1 Colin Walters 2014-10-26 20:58:25 UTC
Created attachment 289385 [details] [review]
libostree: Add ostree_repo_pull_with_options()

We potentially need a lot of argument types for pull.  Rather than
have a C function with tons of arguments, let's use a GVariant a{sv}
as a handy extensible (and immutable) bag of properties.

This is prepratory work for adding an option to pull to traverse
history.

The first additional flag here is inherit-maincontext, which
is used to fix
Comment 2 Colin Walters 2014-10-27 13:12:18 UTC
This unfortunately breaks the OstreeAsyncProgress API.  I think to make this work sanely, we need to make ostree_repo_pull_with_options_async().

Or alternatively, if you pass an OstreeAsyncProgress to a synchronous pull API, we ignore the default main context for the AsyncProgress, and use the one allocated for the pull?
Comment 3 Colin Walters 2014-10-28 17:38:40 UTC
Review of attachment 289385 [details] [review]:

I pushed a variant of this wish does NOT by default create a new main context.
Comment 4 André Klapper 2018-08-17 18:58:53 UTC
OSTree has moved to Github a while ago.
Furthermore, GNOME Bugzilla will be shut down and replaced by gitlab.gnome.org.

If the problem reported in this Bugzilla ticket is still valid, please report it to https://github.com/ostreedev/ostree/issues instead. Thank you!

Closing this report as WONTFIX as part of Bugzilla Housekeeping.