After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 73781 - Missing GError return from gnome_url_show
Missing GError return from gnome_url_show
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
unspecified
Other Solaris
: Normal normal
: 2.0.0
Assigned To: Anders Carlsson
Havoc Pennington
Depends on:
Blocks:
 
 
Reported: 2002-03-06 21:45 UTC by Sander Vesik
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sander Vesik 2002-03-06 21:45:43 UTC
gnome terminal is able to launch clicked-on URLs, but presently has no way
to configure which program will be used, it is not reported anywhere and
there is no error feedback (other than a browser window not showing up)
that the operation wasn't successful (say 'program not found' or similar).
Comment 1 Havoc Pennington 2002-03-06 22:18:51 UTC
It uses the gnome-wide URL launcher, which is 
under Applications->Preferences->Advanced->Preferred Programs.
Comment 2 Havoc Pennington 2002-03-09 15:22:14 UTC
I display any errors that libgnome returns from gnome_url_show, 
so it must not be reporting them for whatever goes wrong in your case.
Comment 3 Anders Carlsson 2002-04-08 09:31:17 UTC
Looking at this it seems that the /desktop/applications/browser gconf
key isn't used at all, instead we use the
/desktop/url-handlers/{http|ftp|unknown|etc} gconf keys for
determining what url handler to use.

I think the plan was to be able to configure this through the file
types capplet but I'm not sure.

Also, gnome-url uses g_spawn_async to execute the url handler program
and this function doesn't seem to detect "command not found" errors,
but you know this better than me, Havoc.
Comment 4 Havoc Pennington 2002-04-09 11:27:45 UTC
gspawn certainly _should_ be detecting command not found errors... if
it doesn't that's an issue.
Comment 5 Anders Carlsson 2002-04-09 11:30:59 UTC
I think the problem here is that we launch /bin/bash with the
executable as an argument, so we're getting the not found message from
bash. Can we launch the web browser without using the shell?

Comment 6 Havoc Pennington 2002-04-09 12:45:36 UTC
I personally tend to think we shouldn't use the shell (for this and 
also for security reasons). George is the main person who's
historically disagreed.
Comment 7 Anders Carlsson 2002-04-09 13:18:43 UTC
OK, I agree with you here. Any reason why George thinks we should use
the shell?
Comment 8 Havoc Pennington 2002-04-09 15:12:29 UTC
Presumably so you can use shell syntax. I don't think it's useful
though. I vote to kill it.
Comment 9 Anders Carlsson 2002-04-09 17:30:04 UTC
OK, I've fixed this in CVS.

Havoc: If you have time, please have a look at gnome-url.c and verify
that I haven't done anything wrong.